Re: [PATCH] drm/tilcdc: Remove redundant OF_DETACHED flag setting

[Jyri Sarha <jsarha@ti.com>]


Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

On 10/13/17 10:47, Stephen Boyd wrote:
> of_fdt_unflatten_tree() already sets the flag on this node to
> OF_DETACHED, because of_fdt_unflatten_tree() calls
> __unflatten_device_tree() with the detached bool set to true.
> 
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Frank Rowand <frowand.list@gmail.com>
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> index 623a9140493c..482299a6f3b0 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_slave_compat.c
> @@ -163,7 +163,6 @@ static struct device_node * __init tilcdc_get_overlay(struct kfree_table *kft)
>  		return NULL;
>  	}
>  
> -	of_node_set_flag(overlay, OF_DETACHED);
>  	ret = of_resolve_phandles(overlay);
>  	if (ret) {
>  		pr_err("%s: Failed to resolve phandles: %d\n", __func__, ret);
> 

Acked-by: Jyri Sarha <jsarha@gmail.com>

I'll pick this up for my next pull request.