* [PATCH V1] mmc: sdhci: Fix sdhci_do_enable_v4_mode
@ 2018-12-13 20:34 Sowjanya Komatineni
2018-12-14 7:34 ` Adrian Hunter
2018-12-17 8:07 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Sowjanya Komatineni @ 2018-12-13 20:34 UTC (permalink / raw)
To: adrian.hunter, ulf.hansson, linux-mmc
Cc: thierry.reding, jonathanh, linux-tegra, linux-kernel,
Sowjanya Komatineni
V4_MODE is Bit-15 of SDHCI_HOST_CONTROL2 register.
Need to perform word access to this register.
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
drivers/mmc/host/sdhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 99bdae53fa2e..fde984d10619 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -127,12 +127,12 @@ static void sdhci_do_enable_v4_mode(struct sdhci_host *host)
{
u16 ctrl2;
- ctrl2 = sdhci_readb(host, SDHCI_HOST_CONTROL2);
+ ctrl2 = sdhci_readw(host, SDHCI_HOST_CONTROL2);
if (ctrl2 & SDHCI_CTRL_V4_MODE)
return;
ctrl2 |= SDHCI_CTRL_V4_MODE;
- sdhci_writeb(host, ctrl2, SDHCI_HOST_CONTROL);
+ sdhci_writew(host, ctrl2, SDHCI_HOST_CONTROL2);
}
/*
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V1] mmc: sdhci: Fix sdhci_do_enable_v4_mode
2018-12-13 20:34 [PATCH V1] mmc: sdhci: Fix sdhci_do_enable_v4_mode Sowjanya Komatineni
@ 2018-12-14 7:34 ` Adrian Hunter
2018-12-17 8:07 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Adrian Hunter @ 2018-12-14 7:34 UTC (permalink / raw)
To: Sowjanya Komatineni, ulf.hansson, linux-mmc
Cc: thierry.reding, jonathanh, linux-tegra, linux-kernel
On 13/12/18 10:34 PM, Sowjanya Komatineni wrote:
> V4_MODE is Bit-15 of SDHCI_HOST_CONTROL2 register.
> Need to perform word access to this register.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
Fixes: b3f80b434f726 ("mmc: sdhci: Add sd host v4 mode")
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> drivers/mmc/host/sdhci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 99bdae53fa2e..fde984d10619 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -127,12 +127,12 @@ static void sdhci_do_enable_v4_mode(struct sdhci_host *host)
> {
> u16 ctrl2;
>
> - ctrl2 = sdhci_readb(host, SDHCI_HOST_CONTROL2);
> + ctrl2 = sdhci_readw(host, SDHCI_HOST_CONTROL2);
> if (ctrl2 & SDHCI_CTRL_V4_MODE)
> return;
>
> ctrl2 |= SDHCI_CTRL_V4_MODE;
> - sdhci_writeb(host, ctrl2, SDHCI_HOST_CONTROL);
> + sdhci_writew(host, ctrl2, SDHCI_HOST_CONTROL2);
> }
>
> /*
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V1] mmc: sdhci: Fix sdhci_do_enable_v4_mode
2018-12-13 20:34 [PATCH V1] mmc: sdhci: Fix sdhci_do_enable_v4_mode Sowjanya Komatineni
2018-12-14 7:34 ` Adrian Hunter
@ 2018-12-17 8:07 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2018-12-17 8:07 UTC (permalink / raw)
To: Sowjanya Komatineni
Cc: Adrian Hunter, linux-mmc, Thierry Reding, Jon Hunter,
linux-tegra, Linux Kernel Mailing List
On Thu, 13 Dec 2018 at 21:34, Sowjanya Komatineni
<skomatineni@nvidia.com> wrote:
>
> V4_MODE is Bit-15 of SDHCI_HOST_CONTROL2 register.
> Need to perform word access to this register.
>
> Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
Applied for fixes, thanks!
Kind regards
Uffe
> ---
> drivers/mmc/host/sdhci.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
> index 99bdae53fa2e..fde984d10619 100644
> --- a/drivers/mmc/host/sdhci.c
> +++ b/drivers/mmc/host/sdhci.c
> @@ -127,12 +127,12 @@ static void sdhci_do_enable_v4_mode(struct sdhci_host *host)
> {
> u16 ctrl2;
>
> - ctrl2 = sdhci_readb(host, SDHCI_HOST_CONTROL2);
> + ctrl2 = sdhci_readw(host, SDHCI_HOST_CONTROL2);
> if (ctrl2 & SDHCI_CTRL_V4_MODE)
> return;
>
> ctrl2 |= SDHCI_CTRL_V4_MODE;
> - sdhci_writeb(host, ctrl2, SDHCI_HOST_CONTROL);
> + sdhci_writew(host, ctrl2, SDHCI_HOST_CONTROL2);
> }
>
> /*
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-12-17 8:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-13 20:34 [PATCH V1] mmc: sdhci: Fix sdhci_do_enable_v4_mode Sowjanya Komatineni
2018-12-14 7:34 ` Adrian Hunter
2018-12-17 8:07 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®