From: Jon Hunter <jonathanh@nvidia.com>
To: Masahiro Yamada <yamada.masahiro@socionext.com>,
<dmaengine@vger.kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Thierry Reding <thierry.reding@gmail.com>,
Peter Griffin <peter.griffin@linaro.org>,
<linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Stephen Warren <swarren@wwwdotorg.org>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vinod.koul@intel.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
"Alexandre Courbot" <gnurou@gmail.com>
Subject: Re: [PATCH] dmaengine: squash lines for immediate return
Date: Tue, 13 Sep 2016 09:45:18 +0100 [thread overview]
Message-ID: <3c992f57-8397-d46a-59be-55dd9457e890@nvidia.com> (raw)
In-Reply-To: <1473708054-30989-1-git-send-email-yamada.masahiro@socionext.com>
On 12/09/16 20:20, Masahiro Yamada wrote:
> Remove unneeded variables and assignments.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> drivers/dma/cppi41.c | 30 +++++-------------------------
> drivers/dma/imx-sdma.c | 15 ++++-----------
> drivers/dma/ppc4xx/adma.c | 15 ++++++---------
> drivers/dma/tegra20-apb-dma.c | 4 +---
> 4 files changed, 16 insertions(+), 48 deletions(-)
...
> diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c
> index 6ab9eb9..89795a2 100644
> --- a/drivers/dma/tegra20-apb-dma.c
> +++ b/drivers/dma/tegra20-apb-dma.c
> @@ -337,9 +337,7 @@ static struct tegra_dma_sg_req *tegra_dma_sg_req_get(
> }
> spin_unlock_irqrestore(&tdc->lock, flags);
>
> - sg_req = kzalloc(sizeof(struct tegra_dma_sg_req), GFP_NOWAIT);
> -
> - return sg_req;
> + return kzalloc(sizeof(struct tegra_dma_sg_req), GFP_NOWAIT);
> }
>
> static int tegra_dma_slave_config(struct dma_chan *dc,
For the Tegra bit ...
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Cheers
Jon
--
nvpublic
next prev parent reply other threads:[~2016-09-13 8:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 19:20 Masahiro Yamada
2016-09-13 8:45 ` Jon Hunter [this message]
2016-09-14 13:37 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c992f57-8397-d46a-59be-55dd9457e890@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gnurou@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=swarren@wwwdotorg.org \
--cc=thierry.reding@gmail.com \
--cc=vinod.koul@intel.com \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®