From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Gonda <pgonda@google.com>
Cc: kvm list <kvm@vger.kernel.org>,
Sean Christopherson <seanjc@google.com>,
Marc Orr <marcorr@google.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] KVM: SEV: Allow SEV intra-host migration of VM with mirrors
Date: Mon, 14 Feb 2022 18:22:44 +0100 [thread overview]
Message-ID: <3caa56dc-ec80-a172-a632-42689aaf6f0b@redhat.com> (raw)
In-Reply-To: <CAMkAt6rLafSikpQEKkbbT8DW4OG_pDL63jPLtCFiO1NNtTRe+A@mail.gmail.com>
On 2/14/22 16:52, Peter Gonda wrote:
> On Mon, Feb 14, 2022 at 5:57 AM Paolo Bonzini <pbonzini@redhat.com> wrote:
>>
>> On 2/11/22 20:36, Peter Gonda wrote:
>>> + list_cut_before(&dst->mirror_vms, &src->mirror_vms, &src->mirror_vms);
>>> + list_for_each_entry_safe(mirror, tmp, &dst->mirror_vms,
>>> + mirror_entry) {
>>
>> Is list_for_each_entry_safe actually necessary here? (It would be if
>> you used list_add/list_del instead of list_cut_before).
>
> I don't think so, I think we could use list_for_each_entry here. Do
> you want me to send another revision?
No, I can do that myself, thanks!
Paolo
next prev parent reply other threads:[~2022-02-14 17:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 19:36 Peter Gonda
2022-02-14 12:57 ` Paolo Bonzini
2022-02-14 15:52 ` Peter Gonda
2022-02-14 17:22 ` Paolo Bonzini [this message]
2022-02-18 9:43 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3caa56dc-ec80-a172-a632-42689aaf6f0b@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcorr@google.com \
--cc=pgonda@google.com \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®