mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Gonda <pgonda@google.com>, kvm@vger.kernel.org
Cc: Sean Christopherson <seanjc@google.com>,
	Marc Orr <marcorr@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] KVM: SEV: Allow SEV intra-host migration of VM with mirrors
Date: Mon, 14 Feb 2022 13:57:31 +0100	[thread overview]
Message-ID: <a3008754-86a8-88d6-df7f-a2770b0a2c93@redhat.com> (raw)
In-Reply-To: <20220211193634.3183388-1-pgonda@google.com>

On 2/11/22 20:36, Peter Gonda wrote:
> +	list_cut_before(&dst->mirror_vms, &src->mirror_vms, &src->mirror_vms);
> +	list_for_each_entry_safe(mirror, tmp, &dst->mirror_vms,
> +				 mirror_entry) {

Is list_for_each_entry_safe actually necessary here?  (It would be if 
you used list_add/list_del instead of list_cut_before).

> +		kvm_get_kvm(dst_kvm);
> +		kvm_put_kvm(src_kvm);
> +		mirror->enc_context_owner = dst_kvm;
> +	}

Thanks,

Paolo


  reply	other threads:[~2022-02-14 12:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-11 19:36 Peter Gonda
2022-02-14 12:57 ` Paolo Bonzini [this message]
2022-02-14 15:52   ` Peter Gonda
2022-02-14 17:22     ` Paolo Bonzini
2022-02-18  9:43 ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a3008754-86a8-88d6-df7f-a2770b0a2c93@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcorr@google.com \
    --cc=pgonda@google.com \
    --cc=seanjc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®