From: "Slark Xiao" <slark_xiao@163.com>
To: "Jeff Hugo" <jeff.hugo@oss.qualcomm.com>
Cc: mani@kernel.org, bbhatt@codeaurora.org, mhi@lists.linux.dev,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re:Re: [PATCH] bus: mhi: host: Only expose controller sysfs attributes on the controller device
Date: Wed, 18 Nov 2026 15:05:10 +0800 (CST) [thread overview]
Message-ID: <3cb75687.54e4.1a1ed794488.Coremail.slark_xiao@163.com> (raw)
In-Reply-To: <826c1746-137b-4a5a-968e-8e0449a25e78@oss.qualcomm.com>
At 2026-11-14 02:42:46, "Jeff Hugo" <jeff.hugo@oss.qualcomm.com> wrote:
>On 11/11/2026 4:56 AM, Slark Xiao wrote:
>> The serial_number, oem_pk_hash and soc_reset attributes are registered
>> through mhi_bus_type.dev_groups, so the driver core creates them for
>> every device on the MHI bus. MHI client devices (the per-channel
>> devices such as mhi0_DUN or mhi0_MBIM) are also MHI bus devices, so
>> each of them ends up with its own copies of these files even though
>> they all operate on the same mhi_controller:
>>
>> $ ls /sys/bus/mhi/devices/mhi0_DUN/
>> driver oem_pk_hash power serial_number soc_reset subsystem uevent
>>
>> This is wrong for several reasons:
>>
>> - The attributes describe the controller, not the channel. Their
>> callbacks all dereference mhi_dev->mhi_cntrl and read BHI registers
>> or issue a controller-wide SoC reset, so writing soc_reset through
>> mhi0_DUN resets the whole device while looking like a per-channel
>> operation.
>> - oem_pk_hash reports failures with dev_err(dev, ...), so a single
>> failing controller produces one log line per registered channel
>> device instead of one.
>> - Userspace has no way to tell which copy is authoritative.
>>
>> Move the attributes off the bus and attach them to the controller
>> device only. mhi_register_controller() now installs the group via
>> mhi_dev->dev.groups before device_add(), while the channel devices
>> created by mhi_create_devices() are left untouched. No functional
>> change for the controller device; the files stay at the paths listed
>> in Documentation/ABI/stable/sysfs-bus-mhi.
>>
>> Note that trigger_edl was already handled this way, through an explicit
>> sysfs_create_file() on the controller kobject, which is why it never
>> appeared on the channel devices.
>I agree with the rationale, but this does appear to change uAPI. Are you
>sure no one is using these on the channel devices?
>
>-Jeff
Hi Jeff,
For oem_pk_hash and serial_number, all interface returns same value.
I think there is no need to keep these interfaces under the channel
devices.
For soc_reset, it write the register directly and it works for the entire
device rather than a single channel.
So I think there is no problem to remove them.
Additionally, I reported this to Mani a long time ago, and he confirmed
that it was indeed a bug.
2024/7/24:
Slark: Hi Mani, do you think if it's a bug? The soc_reset and other
attr would be enumerated both the mhi0 and other mhi0_PORT
Mani: Gosh, yes
They belong to the controller
Can you send a patch? Else I'll fix it
Thanks
prev parent reply other threads:[~2026-11-18 7:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 11:56 Slark Xiao
2026-11-13 18:42 ` Jeff Hugo
2026-11-18 7:05 ` Slark Xiao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cb75687.54e4.1a1ed794488.Coremail.slark_xiao@163.com \
--to=slark_xiao@163.com \
--cc=bbhatt@codeaurora.org \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mhi@lists.linux.dev \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®