Re: [RFC PATCH 05/11] drivers/acpi: convert seqno counter_atomic

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

From: Shuah Khan <skhan@linuxfoundation.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Len Brown <lenb@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Kees Cook <keescook@chromium.org>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [RFC PATCH 05/11] drivers/acpi: convert seqno counter_atomic
Date: Thu, 24 Sep 2020 09:08:32 -0600	[thread overview]
Message-ID: <3cc1e840-6525-e125-499a-03b9c86c0243@linuxfoundation.org> (raw)
In-Reply-To: <CAJZ5v0iS2wpvvJGLsEJSSdCJ0tf4DmJ9fQWVU3PzFuMB7Zbkjw@mail.gmail.com>

On 9/24/20 5:13 AM, Rafael J. Wysocki wrote:
> On Wed, Sep 23, 2020 at 3:44 AM Shuah Khan <skhan@linuxfoundation.org> wrote:
>>
>> counter_atomic is introduced to be used when a variable is used as
>> a simple counter and doesn't guard object lifetimes. This clearly
>> differentiates atomic_t usages that guard object lifetimes.
>>
>> counter_atomic variables will wrap around to 0 when it overflows and
>> should not be used to guard resource lifetimes, device usage and
>> open counts that control state changes, and pm states.
>>
>> seqno is a sequence number counter for logging. This counter gets
>> incremented. Unsure if there is a chance of this overflowing. It
>> doesn't look like overflowing causes any problems since it is used
>> to tag the log messages and nothing more.
>>
>> Convert it to use counter_atomic.
>>
>> This conversion doesn't change the oveflow wrap around behavior.

I see typo here. Will fix it.

>>
>> Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
> 
> Both this change and the next patch are fine by me.
> 

Thanks Rafael. Okay to add your Acked-by?

thanks,
-- Shuah

next prev parent reply	other threads:[~2020-09-24 15:08 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23  1:43 [RFC PATCH 00/11] Introduce Simple atomic and non-atomic counters Shuah Khan
2020-09-23  1:43 ` [RFC PATCH 01/11] counters: Introduce counter and counter_atomic Shuah Khan
2020-09-23 10:35   ` Greg KH
2020-09-23 19:04   ` Kees Cook
2020-09-23 19:34     ` Greg KH
2020-09-23 20:54       ` Kees Cook
2020-09-23 20:48     ` Shuah Khan
2020-09-23 20:58       ` Kees Cook
2020-09-23 21:19         ` Shuah Khan
2020-09-23 22:04           ` Kees Cook
2020-09-23  1:43 ` [RFC PATCH 02/11] selftests:lib: add new test for counters Shuah Khan
2020-09-23  1:43 ` [RFC PATCH 03/11] drivers/base: convert deferred_trigger_count and probe_count to counter_atomic Shuah Khan
2020-09-23 10:30   ` Greg KH
2020-09-23  1:43 ` [RFC PATCH 04/11] drivers/base/devcoredump: convert devcd_count " Shuah Khan
2020-09-23 10:31   ` Greg KH
2020-09-23  1:43 ` [RFC PATCH 05/11] drivers/acpi: convert seqno counter_atomic Shuah Khan
2020-09-24 11:13   ` Rafael J. Wysocki
2020-09-24 15:08     ` Shuah Khan [this message]
2020-09-24 15:32       ` Rafael J. Wysocki
2020-09-23  1:43 ` [RFC PATCH 06/11] drivers/acpi/apei: " Shuah Khan
2020-09-23  1:43 ` [RFC PATCH 07/11] drivers/android/binder: convert stats, transaction_log to counter_atomic Shuah Khan
2020-09-23  5:10   ` Greg KH
2020-09-23 19:04     ` Kees Cook
2020-09-23 19:31       ` Greg KH
2020-09-23 20:51         ` Kees Cook
2020-09-23  1:43 ` [RFC PATCH 08/11] drivers/base/test/test_async_driver_probe: convert to use counter_atomic Shuah Khan
2020-09-23 10:33   ` Greg KH
2020-09-23  1:43 ` [RFC PATCH 09/11] drivers/char/ipmi: convert stats " Shuah Khan
2020-09-23  1:43 ` [RFC PATCH 10/11] drivers/misc/vmw_vmci: convert num guest devices counter to counter_atomic Shuah Khan
2020-09-23 10:29   ` Greg KH
2020-09-23  1:43 ` [RFC PATCH 11/11] drivers/edac: convert pci counters " Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cc1e840-6525-e125-499a-03b9c86c0243@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=keescook@chromium.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®