mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: johannes@sipsolutions.net, gregkh@linuxfoundation.org,
	rafael@kernel.org, keescook@chromium.org
Cc: Shuah Khan <skhan@linuxfoundation.org>, linux-kernel@vger.kernel.org
Subject: [RFC PATCH 04/11] drivers/base/devcoredump: convert devcd_count to counter_atomic
Date: Tue, 22 Sep 2020 19:43:33 -0600	[thread overview]
Message-ID: <651bc1a1e1cbf5e2a1b9f60118d5c163b93eeb43.1600816121.git.skhan@linuxfoundation.org> (raw)
In-Reply-To: <cover.1600816121.git.skhan@linuxfoundation.org>

counter_atomic is introduced to be used when a variable is used as
a simple counter and doesn't guard object lifetimes. This clearly
differentiates atomic_t usages that guard object lifetimes.

counter_atomic variables will wrap around to 0 when it overflows and
should not be used to guard resource lifetimes, device usage and
open counts that control state changes, and pm states.

devcd_count is used to track dev_coredumpm device count and used in
device name string. It doesn't guard object lifetimes, device usage
counts, device open counts, and pm states. There is very little chance
of this counter overflowing. Convert it to use counter_atomic.

This conversion doesn't change the oveflow wrap around behavior.

Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
---
 drivers/base/devcoredump.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/base/devcoredump.c b/drivers/base/devcoredump.c
index e42d0b514384..d719424d1e0b 100644
--- a/drivers/base/devcoredump.c
+++ b/drivers/base/devcoredump.c
@@ -16,6 +16,7 @@
 #include <linux/slab.h>
 #include <linux/fs.h>
 #include <linux/workqueue.h>
+#include <linux/counters.h>
 
 static struct class devcd_class;
 
@@ -255,7 +256,7 @@ void dev_coredumpm(struct device *dev, struct module *owner,
 				   void *data, size_t datalen),
 		   void (*free)(void *data))
 {
-	static atomic_t devcd_count = ATOMIC_INIT(0);
+	static struct counter_atomic devcd_count = COUNTER_ATOMIC_INIT(0);
 	struct devcd_entry *devcd;
 	struct device *existing;
 
@@ -286,7 +287,7 @@ void dev_coredumpm(struct device *dev, struct module *owner,
 	device_initialize(&devcd->devcd_dev);
 
 	dev_set_name(&devcd->devcd_dev, "devcd%d",
-		     atomic_inc_return(&devcd_count));
+		     counter_atomic_inc_return(&devcd_count));
 	devcd->devcd_dev.class = &devcd_class;
 
 	if (device_add(&devcd->devcd_dev))
-- 
2.25.1


  parent reply	other threads:[~2020-09-23  1:44 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23  1:43 [RFC PATCH 00/11] Introduce Simple atomic and non-atomic counters Shuah Khan
2020-09-23  1:43 ` [RFC PATCH 01/11] counters: Introduce counter and counter_atomic Shuah Khan
2020-09-23 10:35   ` Greg KH
2020-09-23 19:04   ` Kees Cook
2020-09-23 19:34     ` Greg KH
2020-09-23 20:54       ` Kees Cook
2020-09-23 20:48     ` Shuah Khan
2020-09-23 20:58       ` Kees Cook
2020-09-23 21:19         ` Shuah Khan
2020-09-23 22:04           ` Kees Cook
2020-09-23  1:43 ` [RFC PATCH 02/11] selftests:lib: add new test for counters Shuah Khan
2020-09-23  1:43 ` [RFC PATCH 03/11] drivers/base: convert deferred_trigger_count and probe_count to counter_atomic Shuah Khan
2020-09-23 10:30   ` Greg KH
2020-09-23  1:43 ` Shuah Khan [this message]
2020-09-23 10:31   ` [RFC PATCH 04/11] drivers/base/devcoredump: convert devcd_count " Greg KH
2020-09-23  1:43 ` [RFC PATCH 05/11] drivers/acpi: convert seqno counter_atomic Shuah Khan
2020-09-24 11:13   ` Rafael J. Wysocki
2020-09-24 15:08     ` Shuah Khan
2020-09-24 15:32       ` Rafael J. Wysocki
2020-09-23  1:43 ` [RFC PATCH 06/11] drivers/acpi/apei: " Shuah Khan
2020-09-23  1:43 ` [RFC PATCH 07/11] drivers/android/binder: convert stats, transaction_log to counter_atomic Shuah Khan
2020-09-23  5:10   ` Greg KH
2020-09-23 19:04     ` Kees Cook
2020-09-23 19:31       ` Greg KH
2020-09-23 20:51         ` Kees Cook
2020-09-23  1:43 ` [RFC PATCH 08/11] drivers/base/test/test_async_driver_probe: convert to use counter_atomic Shuah Khan
2020-09-23 10:33   ` Greg KH
2020-09-23  1:43 ` [RFC PATCH 09/11] drivers/char/ipmi: convert stats " Shuah Khan
2020-09-23  1:43 ` [RFC PATCH 10/11] drivers/misc/vmw_vmci: convert num guest devices counter to counter_atomic Shuah Khan
2020-09-23 10:29   ` Greg KH
2020-09-23  1:43 ` [RFC PATCH 11/11] drivers/edac: convert pci counters " Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=651bc1a1e1cbf5e2a1b9f60118d5c163b93eeb43.1600816121.git.skhan@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=johannes@sipsolutions.net \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®