From: "Arnd Bergmann" <arnd@arndb.de>
To: "Viresh Kumar" <viresh.kumar@linaro.org>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Pierre Gondois" <pierre.gondois@arm.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: airoha: add CONFIG_OF dependency
Date: Mon, 03 Feb 2025 09:04:39 +0100 [thread overview]
Message-ID: <3ccab07b-6cb9-46be-8a8e-e7745f5a951f@app.fastmail.com> (raw)
In-Reply-To: <20250122070000.sawplgg5tfhrvdfw@vireshk-i7>
On Wed, Jan 22, 2025, at 08:00, Viresh Kumar wrote:
>>
>> diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm
>> index 704e84d00639..9e46960f6a86 100644
>> --- a/drivers/cpufreq/Kconfig.arm
>> +++ b/drivers/cpufreq/Kconfig.arm
>> @@ -18,6 +18,7 @@ config ARM_ALLWINNER_SUN50I_CPUFREQ_NVMEM
>> config ARM_AIROHA_SOC_CPUFREQ
>> tristate "Airoha EN7581 SoC CPUFreq support"
>> depends on ARCH_AIROHA || COMPILE_TEST
>> + depends on OF
>> select PM_OPP
>> default ARCH_AIROHA
>> help
>
> Applied. Thanks.
>
It appears that something went wrong when you applied the fix,
the version that is in your tree now makes no sense:
--- a/drivers/cpufreq/Kconfig.arm
+++ b/drivers/cpufreq/Kconfig.arm
@@ -17,7 +17,7 @@ config ARM_ALLWINNER_SUN50I_CPUFREQ_NVMEM
config ARM_AIROHA_SOC_CPUFREQ
tristate "Airoha EN7581 SoC CPUFreq support"
- depends on ARCH_AIROHA || COMPILE_TEST
+ depends on (ARCH_AIROHA && OF) || COMPILE_TEST
select PM_OPP
default ARCH_AIROHA
help
ARCH_AIROHA requires CONFIG_OF, so this change does nothing,
and the dependency is still missing for the COMPILE_TEST case.
Arnd
next prev parent reply other threads:[~2025-02-03 8:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 6:55 Arnd Bergmann
2025-01-22 7:00 ` Viresh Kumar
2025-02-03 8:04 ` Arnd Bergmann [this message]
2025-02-03 9:21 ` Viresh Kumar
2025-02-03 10:54 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ccab07b-6cb9-46be-8a8e-e7745f5a951f@app.fastmail.com \
--to=arnd@arndb.de \
--cc=ansuelsmth@gmail.com \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®