From: "Arnd Bergmann" <arnd@arndb.de>
To: "Viresh Kumar" <viresh.kumar@linaro.org>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Pierre Gondois" <pierre.gondois@arm.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: airoha: add CONFIG_OF dependency
Date: Mon, 03 Feb 2025 11:54:21 +0100 [thread overview]
Message-ID: <d1ed3940-976b-47d0-b5e0-9bf08f687246@app.fastmail.com> (raw)
In-Reply-To: <20250203092141.irtn3qf5feowg4jt@vireshk-i7>
On Mon, Feb 3, 2025, at 10:21, Viresh Kumar wrote:
>
> Going to send this patch now, lemme know if it looks okay:
>
>
> It would be possible to mark the variable as __maybe_unused to shut up
> that warning, but a Kconfig dependency seems more appropriate as this still
> allows build testing in allmodconfig and randconfig builds on all
> architectures.
>
> An earlier commit, b865a8404642 ("cpufreq: airoha: Depends on OF"),
> tried to fix it incorrectly. ARCH_AIROHA already requires CONFIG_OF, so
> this change does nothing, and the dependency is still missing for the
> COMPILE_TEST case.
>
> Fix it properly.
>
> Fixes: 84cf9e541ccc ("cpufreq: airoha: Add EN7581 CPUFreq SMCCC driver")
> Fixes: b865a8404642 ("cpufreq: airoha: Depends on OF")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> [ Viresh: updated commit log and fixed rebase conflict ]
> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Looks good to me, thanks!
Arnd
prev parent reply other threads:[~2025-02-03 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-22 6:55 Arnd Bergmann
2025-01-22 7:00 ` Viresh Kumar
2025-02-03 8:04 ` Arnd Bergmann
2025-02-03 9:21 ` Viresh Kumar
2025-02-03 10:54 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d1ed3940-976b-47d0-b5e0-9bf08f687246@app.fastmail.com \
--to=arnd@arndb.de \
--cc=ansuelsmth@gmail.com \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pierre.gondois@arm.com \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®