mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v5] staging: gpib: Remove commented-out debug code
@ 2025-01-10 23:38 Sandeep Salwan
  2025-01-11  8:35 ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Sandeep Salwan @ 2025-01-10 23:38 UTC (permalink / raw)
  To: gregkh, dan.carpenter; +Cc: linux-staging, linux-kernel, Sandeep Salwan

Code cleanup. This code has some debug code which is commented out.
Delete it.

Signed-off-by: Sandeep Salwan <salwansandeep5@gmail.com>
---
v5: fix version location
v4: fix title description
v3: remove leftover braces, re-write commit message
v2: removed commented-out code only
---
 drivers/staging/gpib/agilent_82350b/agilent_82350b.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
index 53006d0cc79c..fd05f15a683e 100644
--- a/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
+++ b/drivers/staging/gpib/agilent_82350b/agilent_82350b.c
@@ -30,11 +30,8 @@ int agilent_82350b_accel_read(gpib_board_t *board, uint8_t *buffer, size_t lengt
 	unsigned short event_status;
 	int i, num_fifo_bytes;
 	//hardware doesn't support checking for end-of-string character when using fifo
-	if (tms_priv->eos_flags & REOS) {
-		//pr_info("ag-rd: using tms9914 read for REOS %x EOS %x\n",tms_priv->eos_flags,
-		// tms_priv->eos);
+	if (tms_priv->eos_flags & REOS)
 		return tms9914_read(board, tms_priv, buffer, length, end, bytes_read);
-	}
 
 	clear_bit(DEV_CLEAR_BN, &tms_priv->state);
 
-- 
2.47.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v5] staging: gpib: Remove commented-out debug code
  2025-01-10 23:38 [PATCH v5] staging: gpib: Remove commented-out debug code Sandeep Salwan
@ 2025-01-11  8:35 ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2025-01-11  8:35 UTC (permalink / raw)
  To: Sandeep Salwan; +Cc: gregkh, linux-staging, linux-kernel

On Fri, Jan 10, 2025 at 06:38:34PM -0500, Sandeep Salwan wrote:
> Code cleanup. This code has some debug code which is commented out.
> Delete it.
> 
> Signed-off-by: Sandeep Salwan <salwansandeep5@gmail.com>
> ---

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-01-11  8:35 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-01-10 23:38 [PATCH v5] staging: gpib: Remove commented-out debug code Sandeep Salwan
2025-01-11  8:35 ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®