From: Krzysztof Kozlowski <krzk@kernel.org>
To: wenhua lin <wenhua.lin1994@gmail.com>
Cc: Stanislav Jakubek <stano.jakubek@gmail.com>,
wenhua.lin@unisoc.com, Zhaochen.Su@unisoc.com,
Zhirong.Qiu@unisoc.com, baolin.wang@linux.alibaba.com,
brgl@bgdev.pl, cixi.geng@linux.dev, conor+dt@kernel.org,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
jirislaby@kernel.org, krzk+dt@kernel.org,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
orsonzhai@gmail.com, robh@kernel.org, xiongpeng.wu@unisoc.com,
zhang.lyra@gmail.com
Subject: Re: [PATCH 2/2] dt-bindings: serial: Add a new compatible string for ums9632
Date: Mon, 13 Jan 2025 08:42:04 +0100 [thread overview]
Message-ID: <3d2504b7-a566-4921-b04c-0eb272c93bae@kernel.org> (raw)
In-Reply-To: <CAB9BWhdAQS5f2OpH8-PZXCWtWWybPJ+UaLvQNu4UacPF_sCg2A@mail.gmail.com>
On 13/01/2025 03:29, wenhua lin wrote:
> On Thu, Nov 21, 2024 at 9:34 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> On 21/11/2024 13:26, Stanislav Jakubek wrote:
>>> Correct me if I'm wrong, but this patch seems incorrect to me.
>>> The 1st patch suggets that the sc9632-uart is incompatible with sc9836-uart,
>>> but here you make it fallback to it anyway.
>>>
>>> Also, both of the patches seem to have made it to linux-next without the
>>> reviews/Acks from maintainers. Maybe Greg was a bit too fast here :)
>>
>> Yeah, this looks odd and considering totally empty commit msg (nothing
>> useful there), it looks like wrong choice.
>>
>> Please explain the compatibility aspects. In the future: you have entire
>> commit msg to describe the hardware, instead of repeating the obvious -
>> what is visible from the diff.
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof:
> Thank you very much for your review, we will correct it in patch v2.
I wrote - commit msg, not changelog. Sigh...
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-13 7:42 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 11:05 [PATCH 0/2] serial: sprd: Modification of UNISOC Platform UART Driver Wenhua Lin
2024-11-13 11:05 ` [PATCH 1/2] serial: sprd: Add support for sc9632 Wenhua Lin
2024-11-15 5:47 ` Baolin Wang
2024-11-15 7:46 ` wenhua lin
2024-11-15 8:06 ` Baolin Wang
2024-11-15 8:39 ` cixi.geng
2024-11-13 11:05 ` [PATCH 2/2] dt-bindings: serial: Add a new compatible string for ums9632 Wenhua Lin
2024-11-14 20:12 ` Conor Dooley
2024-11-15 8:40 ` cixi.geng
2024-11-21 12:26 ` Stanislav Jakubek
2024-11-21 13:34 ` Krzysztof Kozlowski
2025-01-13 2:29 ` wenhua lin
2025-01-13 7:42 ` Krzysztof Kozlowski [this message]
2025-01-13 2:29 ` wenhua lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d2504b7-a566-4921-b04c-0eb272c93bae@kernel.org \
--to=krzk@kernel.org \
--cc=Zhaochen.Su@unisoc.com \
--cc=Zhirong.Qiu@unisoc.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=brgl@bgdev.pl \
--cc=cixi.geng@linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh@kernel.org \
--cc=stano.jakubek@gmail.com \
--cc=wenhua.lin1994@gmail.com \
--cc=wenhua.lin@unisoc.com \
--cc=xiongpeng.wu@unisoc.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®