mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Wenhua Lin <Wenhua.Lin@unisoc.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: Orson Zhai <orsonzhai@gmail.com>,
	Chunyan Zhang <zhang.lyra@gmail.com>,
	Cixi Geng <cixi.geng@linux.dev>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	devicetree@vger.kernel.org, wenhua lin <wenhua.lin1994@gmail.com>,
	Xiongpeng Wu <xiongpeng.wu@unisoc.com>,
	Zhaochen Su <Zhaochen.Su@unisoc.com>,
	Zhirong Qiu <Zhirong.Qiu@unisoc.com>
Subject: Re: [PATCH 1/2] serial: sprd: Add support for sc9632
Date: Fri, 15 Nov 2024 13:47:37 +0800	[thread overview]
Message-ID: <3f89369f-7c0a-47c3-a22a-a125847edb98@linux.alibaba.com> (raw)
In-Reply-To: <20241113110516.2166328-2-Wenhua.Lin@unisoc.com>



On 2024/11/13 19:05, Wenhua Lin wrote:
> Due to the platform's new project uart ip upgrade,
> the new project's timeout interrupt needs to use bit17
> while other projects' timeout interrupt needs to use
> bit13, using private data to adapt and be compatible
> with all projects.
> 
> Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
> ---
>   drivers/tty/serial/sprd_serial.c | 41 ++++++++++++++++++++++++++++----
>   1 file changed, 36 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c
> index 3fc54cc02a1f..882580c3cf37 100644
> --- a/drivers/tty/serial/sprd_serial.c
> +++ b/drivers/tty/serial/sprd_serial.c
> @@ -53,10 +53,12 @@
>   #define SPRD_IEN_TX_EMPTY	BIT(1)
>   #define SPRD_IEN_BREAK_DETECT	BIT(7)
>   #define SPRD_IEN_TIMEOUT	BIT(13)
> +#define SPRD_IEN_DATA_TIMEOUT	BIT(17)

I don't know the meaning of 'DATA' in the new macro name. But I have no 
better name now:) Otherwise look good to me.
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>

  reply	other threads:[~2024-11-15  5:47 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-13 11:05 [PATCH 0/2] serial: sprd: Modification of UNISOC Platform UART Driver Wenhua Lin
2024-11-13 11:05 ` [PATCH 1/2] serial: sprd: Add support for sc9632 Wenhua Lin
2024-11-15  5:47   ` Baolin Wang [this message]
2024-11-15  7:46     ` wenhua lin
2024-11-15  8:06       ` Baolin Wang
2024-11-15  8:39   ` cixi.geng
2024-11-13 11:05 ` [PATCH 2/2] dt-bindings: serial: Add a new compatible string for ums9632 Wenhua Lin
2024-11-14 20:12   ` Conor Dooley
2024-11-15  8:40   ` cixi.geng
2024-11-21 12:26   ` Stanislav Jakubek
2024-11-21 13:34     ` Krzysztof Kozlowski
2025-01-13  2:29       ` wenhua lin
2025-01-13  7:42         ` Krzysztof Kozlowski
2025-01-13  2:29     ` wenhua lin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f89369f-7c0a-47c3-a22a-a125847edb98@linux.alibaba.com \
    --to=baolin.wang@linux.alibaba.com \
    --cc=Wenhua.Lin@unisoc.com \
    --cc=Zhaochen.Su@unisoc.com \
    --cc=Zhirong.Qiu@unisoc.com \
    --cc=brgl@bgdev.pl \
    --cc=cixi.geng@linux.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=orsonzhai@gmail.com \
    --cc=robh@kernel.org \
    --cc=wenhua.lin1994@gmail.com \
    --cc=xiongpeng.wu@unisoc.com \
    --cc=zhang.lyra@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®