* [PATCH] KVM: arm64:Use #include <linux/kprobes.h> instead of <asm/kprobes.h> [not found] <tencent_2099141F01FC6C32AAA20B385053A477C507@qq.com> @ 2023-07-14 4:57 ` chenqingyun001 2023-07-14 7:57 ` Marc Zyngier 0 siblings, 1 reply; 2+ messages in thread From: chenqingyun001 @ 2023-07-14 4:57 UTC (permalink / raw) To: maz, oliver.upton, catalin.marinas, will Cc: kvmarm, linux-kernel, james.morse, suzuki.poulose, yuzenghui Since <asm/kprobes.h> is a kernel-proprietary header file, it should not be included by user-space programs. And <linux/kprobes.h> is a public header file, which provides some functions for registering and unregistering probes Signed-off-by: Qingyun Chen <chenqingyun001@208suo.com> --- arch/arm64/kvm/hyp/vhe/sysreg-sr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/kvm/hyp/vhe/sysreg-sr.c b/arch/arm64/kvm/hyp/vhe/sysreg-sr.c index b35a178e7e0d..072471df8b1b 100644 --- a/arch/arm64/kvm/hyp/vhe/sysreg-sr.c +++ b/arch/arm64/kvm/hyp/vhe/sysreg-sr.c @@ -9,7 +9,7 @@ #include <linux/compiler.h> #include <linux/kvm_host.h> -#include <asm/kprobes.h> +#include <linux/kprobes.h> #include <asm/kvm_asm.h> #include <asm/kvm_emulate.h> #include <asm/kvm_hyp.h> ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: arm64:Use #include <linux/kprobes.h> instead of <asm/kprobes.h> 2023-07-14 4:57 ` [PATCH] KVM: arm64:Use #include <linux/kprobes.h> instead of <asm/kprobes.h> chenqingyun001 @ 2023-07-14 7:57 ` Marc Zyngier 0 siblings, 0 replies; 2+ messages in thread From: Marc Zyngier @ 2023-07-14 7:57 UTC (permalink / raw) To: chenqingyun001 Cc: oliver.upton, catalin.marinas, will, kvmarm, linux-kernel, james.morse, suzuki.poulose, yuzenghui On Fri, 14 Jul 2023 05:57:42 +0100, chenqingyun001@208suo.com wrote: > > Since <asm/kprobes.h> is a kernel-proprietary header file, it > should not be included by user-space programs. There is no userspace involved here. > And <linux/kprobes.h> is a public header file, > which provides some functions for registering > and unregistering probes How is that relevant? Have you checked *why* we're including this file? > > Signed-off-by: Qingyun Chen <chenqingyun001@208suo.com> > --- > arch/arm64/kvm/hyp/vhe/sysreg-sr.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kvm/hyp/vhe/sysreg-sr.c > b/arch/arm64/kvm/hyp/vhe/sysreg-sr.c > index b35a178e7e0d..072471df8b1b 100644 > --- a/arch/arm64/kvm/hyp/vhe/sysreg-sr.c > +++ b/arch/arm64/kvm/hyp/vhe/sysreg-sr.c > @@ -9,7 +9,7 @@ > #include <linux/compiler.h> > #include <linux/kvm_host.h> > > -#include <asm/kprobes.h> > +#include <linux/kprobes.h> And this is at the wrong thing to do. > #include <asm/kvm_asm.h> > #include <asm/kvm_emulate.h> > #include <asm/kvm_hyp.h> > I'd rather you *stop* sending these patches. There is no justification for them, and you keep doing the wrong thing. M. -- Without deviation from the norm, progress is not possible. ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-07-14 8:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tencent_2099141F01FC6C32AAA20B385053A477C507@qq.com>
2023-07-14 4:57 ` [PATCH] KVM: arm64:Use #include <linux/kprobes.h> instead of <asm/kprobes.h> chenqingyun001
2023-07-14 7:57 ` Marc Zyngier
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®