From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: linux-pm@vger.kernel.org,
Vincent Guittot <vincent.guittot@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
Stephan Gerhold <stephan.gerhold@kernkonzept.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V2 1/3] OPP: Level zero is valid
Date: Mon, 30 Oct 2023 19:47:47 +0100 [thread overview]
Message-ID: <3d686b62-13a2-4107-86ff-d9753cb177fb@linaro.org> (raw)
In-Reply-To: <36de122e568dcba371d3581e5f936243b405a874.1698661048.git.viresh.kumar@linaro.org>
On 30.10.2023 11:24, Viresh Kumar wrote:
> The level zero can be used by some OPPs to drop performance state vote
> for the device. It is perfectly fine to allow the same.
>
> _set_opp_level() considers it as an invalid value currently and returns
> early.
So, currently if the device is PM-enabled, but OPP requirements are lifted,
is the API currently internally stuck at the last non-zero level?
Just trying to understand if this could fix some silent issues
Konrad
next prev parent reply other threads:[~2023-10-30 18:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 10:24 [PATCH V2 0/3] OPP: Simplify required-opp handling Viresh Kumar
2023-10-30 10:24 ` [PATCH V2 1/3] OPP: Level zero is valid Viresh Kumar
2023-10-30 18:47 ` Konrad Dybcio [this message]
2023-10-31 5:26 ` Viresh Kumar
2023-10-31 10:07 ` Konrad Dybcio
2023-11-06 15:41 ` Ulf Hansson
2023-10-30 10:24 ` [PATCH V2 2/3] OPP: Use _set_opp_level() for single genpd case Viresh Kumar
2023-10-30 10:24 ` [PATCH V2 3/3] OPP: Call dev_pm_opp_set_opp() for required OPPs Viresh Kumar
2023-11-03 5:28 ` [PATCH V2 0/3] OPP: Simplify required-opp handling Viresh Kumar
2023-11-03 9:20 ` Ulf Hansson
2023-11-03 9:24 ` Stephan Gerhold
2023-11-03 9:27 ` Viresh Kumar
2023-11-16 10:43 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d686b62-13a2-4107-86ff-d9753cb177fb@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=nm@ti.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=stephan.gerhold@kernkonzept.com \
--cc=ulf.hansson@linaro.org \
--cc=vincent.guittot@linaro.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®