mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* Re: [PATCH v7] tty: fix hang on tty device with no_room set
       [not found] ` <ZCuQO3A6FX305KTJ@debian.me>
@ 2023-04-04  2:55   ` Bagas Sanjaya
  2023-04-04  7:02     ` caelli
  0 siblings, 1 reply; 2+ messages in thread
From: Bagas Sanjaya @ 2023-04-04  2:55 UTC (permalink / raw)
  To: juanfengpy
  Cc: Hui Li, stable, Ilpo Järvinen, Greg Kroah-Hartman,
	Linux Kernel Mailing List

On 4/4/23 09:49, Bagas Sanjaya wrote:
> On Fri, Mar 17, 2023 at 10:24:07AM +0800, juanfengpy@gmail.com wrote:
>> We have met a hang on pty device, the reader was blocking
>> at epoll on master side, the writer was sleeping at wait_woken
>> inside n_tty_write on slave side, and the write buffer on
>> tty_port was full, we found that the reader and writer would
>> never be woken again and blocked forever.
> 
> Where do you find this hanging pty? Seems like the wording makes me
> confused. Maybe you mean "It is possible to hang pty device. In that
> case, ..."
> 

Oops, I forgot to Cc: LKML.

-- 
An old man doll... just what I always wanted! - Clara


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH v7] tty: fix hang on tty device with no_room set
  2023-04-04  2:55   ` [PATCH v7] tty: fix hang on tty device with no_room set Bagas Sanjaya
@ 2023-04-04  7:02     ` caelli
  0 siblings, 0 replies; 2+ messages in thread
From: caelli @ 2023-04-04  7:02 UTC (permalink / raw)
  To: Bagas Sanjaya
  Cc: Hui Li, stable, Ilpo Järvinen, Greg Kroah-Hartman,
	Linux Kernel Mailing List

> Where do you find this hanging pty? Seems like the wording makes me
> confused. Maybe you mean "It is possible to hang pty device. In that
> case, ..."

Thanks for your reply, I will correct messages like this:

"It is possible to hang pty devices in this case, the reader
was blocking at epoll on master side, the writer was ..."

Bagas Sanjaya <bagasdotme@gmail.com> 于2023年4月4日周二 10:55写道:
>
> On 4/4/23 09:49, Bagas Sanjaya wrote:
> > On Fri, Mar 17, 2023 at 10:24:07AM +0800, juanfengpy@gmail.com wrote:
> >> We have met a hang on pty device, the reader was blocking
> >> at epoll on master side, the writer was sleeping at wait_woken
> >> inside n_tty_write on slave side, and the write buffer on
> >> tty_port was full, we found that the reader and writer would
> >> never be woken again and blocked forever.
> >
> > Where do you find this hanging pty? Seems like the wording makes me
> > confused. Maybe you mean "It is possible to hang pty device. In that
> > case, ..."
> >
>
> Oops, I forgot to Cc: LKML.
>
> --
> An old man doll... just what I always wanted! - Clara
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-04-04  7:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1679019847-1401-1-git-send-email-caelli@tencent.com>
     [not found] ` <ZCuQO3A6FX305KTJ@debian.me>
2023-04-04  2:55   ` [PATCH v7] tty: fix hang on tty device with no_room set Bagas Sanjaya
2023-04-04  7:02     ` caelli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®