mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Denis Benato <denis.benato@linux.dev>
To: "Paweł Hofman" <phofman@o2.pl>,
	corentin.chary@gmail.com, luke@ljones.dev, hansg@kernel.org,
	ilpo.jarvinen@linux.intel.com,
	platform-driver-x86@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: asus-nb-wmi: add UX7602ZM DMI quirk
Date: Sun, 22 Feb 2026 23:26:31 +0100	[thread overview]
Message-ID: <3dca0acb-2dea-4a65-a98e-8b40c878b076@linux.dev> (raw)
In-Reply-To: <20260222220526.285327-1-phofman@o2.pl>

Hello and than you for this.


There a few things missing here:
- a commit description for the why this was required
- your signed-off-by tag

On 2/22/26 23:05, Paweł Hofman wrote:
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/drivers/platform/x86/asus-nb-wmi.c b/drivers/platform/x86/asus-nb-wmi.c
> index a38a65f5c550..19cd7ea13fef 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -553,6 +553,15 @@ static const struct dmi_system_id asus_quirks[] = {
>  		},
>  		.driver_data = &quirk_asus_z13,
>  	},
> +        {
> +                .callback = dmi_matched,
> +                .ident = "ASUS Zenbook UX7602ZM",
> +                .matches = {
> +                        DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +                        DMI_MATCH(DMI_PRODUCT_NAME, "Zenbook UX7602ZM_UX7602ZM"),
> +                },
> +                .driver_data = &quirk_asus_zenbook_duo_kbd,
> +        },
Please use tabs to align and ensure it is aligned with other entries.

Also keep all quirk_asus_zenbook_duo_kdb entries together please.
>  	{},
>  };
>  

      reply	other threads:[~2026-02-22 22:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-22 22:05 Paweł Hofman
2026-02-22 22:26 ` Denis Benato [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3dca0acb-2dea-4a65-a98e-8b40c878b076@linux.dev \
    --to=denis.benato@linux.dev \
    --cc=corentin.chary@gmail.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke@ljones.dev \
    --cc=phofman@o2.pl \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®