From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Mayank Rungta <mrungta@google.com>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Guenter Roeck <linux@roeck-us.net>,
Thomas Gleixner <tglx@kernel.org>, Radu Rendec <radu@rendec.net>
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
"Kirill A. Shutemov" <kas@kernel.org>,
Douglas Anderson <dianders@chromium.org>
Subject: Re: [PATCH v3 5/5] watchdog: qcom: Register pretimeout interrupt as NMI
Date: Thu, 3 Sep 2026 10:18:14 +0200 [thread overview]
Message-ID: <3de593de-6851-4a53-8309-a6bf13e9a8f7@oss.qualcomm.com> (raw)
In-Reply-To: <20260902-qcom-wdt-nmi-series-v3-5-f3999362a9ea@google.com>
On 9/3/26 3:54 AM, Mayank Rungta wrote:
> When a system is completely unresponsive due to an interrupt storm or
> deadlocked CPU cores with standard interrupts disabled, a standard
> watchdog pretimeout bark interrupt will fail to execute, preventing the
> pretimeout governor from capturing CPU backtraces before the hardware
> reset bite.
[...]
> - ret = devm_request_irq(dev, irq, qcom_wdt_isr, 0,
> - "wdt_bark", &wdt->wdd);
> - if (ret)
> - return ret;
> + wdt->irq = irq;
> + irq_flags = IRQF_PERCPU | IRQF_NOBALANCING |
> + IRQF_NO_AUTOEN | IRQF_NO_THREAD;
> +
> + ret = request_nmi(irq, qcom_wdt_isr, irq_flags,
> + "wdt_bark", &wdt->wdd);
> + if (ret) {
> + /* Fallback to normal interrupt if NMI not supported */
> + ret = devm_request_irq(dev, irq, qcom_wdt_isr, 0,
> + "wdt_bark", &wdt->wdd);
GPT noticed this IRQ is requested but never enabled (NO_AUTOEN)
Konrad
next prev parent reply other threads:[~2026-09-03 8:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 1:54 [PATCH v3 0/5] watchdog: qcom: Support NMI pretimeout warnings Mayank Rungta
2026-09-03 1:54 ` [PATCH v3 1/5] genirq: Synchronize in-flight handlers during NMI teardown Mayank Rungta
2026-09-04 9:17 ` Thomas Gleixner
2026-09-04 13:40 ` Marc Zyngier
2026-09-04 14:34 ` Doug Anderson
2026-09-04 14:57 ` Marc Zyngier
2026-09-04 14:59 ` Doug Anderson
2026-09-04 15:11 ` Thomas Gleixner
2026-09-04 15:26 ` Doug Anderson
2026-09-28 16:14 ` Doug Anderson
2026-09-30 21:46 ` Thomas Gleixner
2026-09-30 23:17 ` Doug Anderson
2026-10-01 18:50 ` Thomas Gleixner
2026-09-03 1:54 ` [PATCH v3 2/5] genirq: Implement synchronous disable_nmi() Mayank Rungta
2026-09-03 1:54 ` [PATCH v3 3/5] genirq: Export NMI APIs Mayank Rungta
2026-09-04 9:29 ` Thomas Gleixner
2026-09-04 14:07 ` Doug Anderson
2026-09-04 15:05 ` Thomas Gleixner
2026-09-05 1:52 ` Mayank Rungta
2026-09-03 1:54 ` [PATCH v3 4/5] watchdog: pretimeout: Protect governor access with RCU for NMI safety Mayank Rungta
2026-09-03 1:54 ` [PATCH v3 5/5] watchdog: qcom: Register pretimeout interrupt as NMI Mayank Rungta
2026-09-03 8:18 ` Konrad Dybcio [this message]
2026-09-03 20:58 ` Mayank Rungta
2026-09-04 7:37 ` Konrad Dybcio
2026-09-04 14:37 ` Doug Anderson
2026-09-05 1:24 ` Mayank Rungta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3de593de-6851-4a53-8309-a6bf13e9a8f7@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=dianders@chromium.org \
--cc=kas@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mrungta@google.com \
--cc=radu@rendec.net \
--cc=tglx@kernel.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®