mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@kernel.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Marc Zyngier <maz@kernel.org>, Mayank Rungta <mrungta@google.com>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Guenter Roeck <linux@roeck-us.net>, Radu Rendec <radu@rendec.net>,
	linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org,
	"Kirill A. Shutemov" <kas@kernel.org>
Subject: Re: [PATCH v3 1/5] genirq: Synchronize in-flight handlers during NMI teardown
Date: Wed, 30 Sep 2026 23:46:13 +0200	[thread overview]
Message-ID: <87o6deh0pm.ffs@fw13> (raw)
In-Reply-To: <CAD=FV=WE-Wn60zTn=nsq4qLis_zjncrS37fND6ehtpuvxYp+DA@mail.gmail.com>

On Mon, Sep 28 2026 at 09:14, Doug Anderson wrote:
> On Fri, Sep 4, 2026 at 8:26 AM Doug Anderson <dianders@chromium.org> wrote:
>> On Fri, Sep 4, 2026 at 8:11 AM Thomas Gleixner <tglx@kernel.org> wrote:
>> > Of course this is a regular global interrupt otherwise it couldn't be
>> > requested normally. So this sets IRQF_PERCPU (it has to otherwise
>> > request_nmi() would fail), but that looks like a hack to me.
>>
>> At least on GIC, promoting a regular global interrupt to NMI (or
>> pseudo-NMI) level is possible, and Mayank's use case here seems
>> legitimate. Any suggestions you have for making this look less like a
>> hack are appreciated! :-)
>
> Throwing an extra plea out here to see if we can make forward
> progress. IMO being able to make watchdog driver "bark" interrupts run
> at NMI (or pseudo-NMI) level is an important thing to do for
> debuggability of the kernel. It sounds as if there are no general
> objections to the idea. I guess the next step is to make this look
> less hacky. Is that something we could send patches for? Any hints for
> what you'd like this to look like would be greatly appreciated.

I think the objections have been layed out in course of the discussion, no?

> I'll also be in Prague next week for both Plumbers and ELCE, so I'd be
> happy to discuss this in person if that helps.

I'm going to be there, but I don't know about Marc.

Thanks,

        tglx

  reply	other threads:[~2026-09-30 21:46 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-03  1:54 [PATCH v3 0/5] watchdog: qcom: Support NMI pretimeout warnings Mayank Rungta
2026-09-03  1:54 ` [PATCH v3 1/5] genirq: Synchronize in-flight handlers during NMI teardown Mayank Rungta
2026-09-04  9:17   ` Thomas Gleixner
2026-09-04 13:40     ` Marc Zyngier
2026-09-04 14:34       ` Doug Anderson
2026-09-04 14:57         ` Marc Zyngier
2026-09-04 14:59           ` Doug Anderson
2026-09-04 15:11       ` Thomas Gleixner
2026-09-04 15:26         ` Doug Anderson
2026-09-28 16:14           ` Doug Anderson
2026-09-30 21:46             ` Thomas Gleixner [this message]
2026-09-30 23:17               ` Doug Anderson
2026-10-01 18:50                 ` Thomas Gleixner
2026-09-03  1:54 ` [PATCH v3 2/5] genirq: Implement synchronous disable_nmi() Mayank Rungta
2026-09-03  1:54 ` [PATCH v3 3/5] genirq: Export NMI APIs Mayank Rungta
2026-09-04  9:29   ` Thomas Gleixner
2026-09-04 14:07     ` Doug Anderson
2026-09-04 15:05       ` Thomas Gleixner
2026-09-05  1:52         ` Mayank Rungta
2026-09-03  1:54 ` [PATCH v3 4/5] watchdog: pretimeout: Protect governor access with RCU for NMI safety Mayank Rungta
2026-09-03  1:54 ` [PATCH v3 5/5] watchdog: qcom: Register pretimeout interrupt as NMI Mayank Rungta
2026-09-03  8:18   ` Konrad Dybcio
2026-09-03 20:58     ` Mayank Rungta
2026-09-04  7:37       ` Konrad Dybcio
2026-09-04 14:37       ` Doug Anderson
2026-09-05  1:24         ` Mayank Rungta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o6deh0pm.ffs@fw13 \
    --to=tglx@kernel.org \
    --cc=dianders@chromium.org \
    --cc=kas@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=maz@kernel.org \
    --cc=mrungta@google.com \
    --cc=radu@rendec.net \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®