From: Jens Axboe <axboe@kernel.dk>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvmet: Reorder fields in 'struct nvmet_ns'
Date: Thu, 27 Apr 2023 17:01:04 -0600 [thread overview]
Message-ID: <3decbaf1-250b-9b73-70fd-4cb9a204c452@kernel.dk> (raw)
In-Reply-To: <ba5df67e-534d-6f79-6277-80c755ca7e94@nvidia.com>
On 4/27/23 4:59?PM, Chaitanya Kulkarni wrote:
> On 4/27/23 12:47, Christophe JAILLET wrote:
>> Group some variables based on their sizes to reduce holes.
>> On x86_64, this shrinks the size of 'struct nvmet_ns' from 520 to 512
>> bytes.
>>
>
> Although this looks good, we at least need to document what
> happens on other arch(s) which are not mentioned in the
> commit log ? is there a possibility that someone might come
> up with the contradictory data in future for the arch(s) which
> arch that are not mentioned here ?
The change is certainly not going to make things _worse_ for any arch,
so I think that's somewhat of a pointless exercise and an unreasonable
ask for something that makes sense on 64-bit arm/x86 and saves half the
space.
--
Jens Axboe
next prev parent reply other threads:[~2023-04-27 23:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-27 19:47 Christophe JAILLET
2023-04-27 22:51 ` Jens Axboe
2023-04-27 22:59 ` Chaitanya Kulkarni
2023-04-27 23:01 ` Jens Axboe [this message]
2023-04-27 23:07 ` Chaitanya Kulkarni
2023-06-19 18:08 ` Christophe JAILLET
2023-06-20 5:21 ` Chaitanya Kulkarni
2023-06-20 15:45 ` Keith Busch
2023-06-21 17:25 ` Keith Busch
2023-04-27 23:12 ` Chaitanya Kulkarni
2023-04-28 7:33 ` Christophe JAILLET
2023-04-28 8:11 ` Chaitanya Kulkarni
2023-05-01 13:58 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3decbaf1-250b-9b73-70fd-4cb9a204c452@kernel.dk \
--to=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=hch@lst.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®