mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Chaitanya Kulkarni <chaitanyak@nvidia.com>,
	Sagi Grimberg <sagi@grimberg.me>,
	"kernel-janitors@vger.kernel.org"
	<kernel-janitors@vger.kernel.org>, Christoph Hellwig <hch@lst.de>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"kbusch@kernel.org" <kbusch@kernel.org>
Subject: Re: [PATCH] nvmet: Reorder fields in 'struct nvmet_ns'
Date: Thu, 27 Apr 2023 23:12:13 +0000	[thread overview]
Message-ID: <67a9e53e-4ac9-7ba8-9713-96c1dfe1e341@nvidia.com> (raw)
In-Reply-To: <aea924d31f2bd2f740b1ccc6f462905bd6cab763.1682624855.git.christophe.jaillet@wanadoo.fr>

(+Keith, for host side)
> ---
> More aggressive grouping could be done to be more future proof, but the
> way the struct nvmet_ns is written suggest that some fields should be
> kept together. So keep grouping as-is.
>
>

you can send RFC and I'll be happy to take a look if it's going
have any benefit, it will take some time though..

for host side :-

while you are at it, it might be useful to take a look at the structures
that are accessed in the fast path on the host side ?

unless there is some reason for not doing that ...

-ck



  parent reply	other threads:[~2023-04-27 23:12 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-27 19:47 Christophe JAILLET
2023-04-27 22:51 ` Jens Axboe
2023-04-27 22:59 ` Chaitanya Kulkarni
2023-04-27 23:01   ` Jens Axboe
2023-04-27 23:07     ` Chaitanya Kulkarni
2023-06-19 18:08       ` Christophe JAILLET
2023-06-20  5:21         ` Chaitanya Kulkarni
2023-06-20 15:45         ` Keith Busch
2023-06-21 17:25           ` Keith Busch
2023-04-27 23:12 ` Chaitanya Kulkarni [this message]
2023-04-28  7:33   ` Christophe JAILLET
2023-04-28  8:11     ` Chaitanya Kulkarni
2023-05-01 13:58 ` Sagi Grimberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67a9e53e-4ac9-7ba8-9713-96c1dfe1e341@nvidia.com \
    --to=chaitanyak@nvidia.com \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®