* [PATCH 1/2] arm64: dts: qcom: sm8750: Change labels to lower-case
@ 2025-02-19 9:07 Krzysztof Kozlowski
2025-02-19 9:07 ` [PATCH 2/2] arm64: dts: qcom: Corret white-space style Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-19 9:07 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
DTS coding style expects labels to be lowercase. No functional impact.
Verified with comparing decompiled DTB (dtx_diff and fdtdump+diff).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8750.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index 3bbd7d18598e..abb92c81c76b 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -95,11 +95,11 @@ cpu6: cpu@10000 {
compatible = "qcom,oryon";
reg = <0x0 0x10000>;
enable-method = "psci";
- next-level-cache = <&L2_1>;
+ next-level-cache = <&l2_1>;
power-domains = <&cpu_pd6>;
power-domain-names = "psci";
- L2_1: l2-cache {
+ l2_1: l2-cache {
compatible = "cache";
cache-level = <2>;
cache-unified;
@@ -111,7 +111,7 @@ cpu7: cpu@10100 {
compatible = "qcom,oryon";
reg = <0x0 0x10100>;
enable-method = "psci";
- next-level-cache = <&L2_1>;
+ next-level-cache = <&l2_1>;
power-domains = <&cpu_pd7>;
power-domain-names = "psci";
};
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: qcom: Corret white-space style
2025-02-19 9:07 [PATCH 1/2] arm64: dts: qcom: sm8750: Change labels to lower-case Krzysztof Kozlowski
@ 2025-02-19 9:07 ` Krzysztof Kozlowski
2025-02-19 9:14 ` Konrad Dybcio
2025-02-20 12:23 ` Markus Elfring
2025-02-19 9:11 ` [PATCH 1/2] arm64: dts: qcom: sm8750: Change labels to lower-case Konrad Dybcio
2025-03-04 17:00 ` (subset) " Bjorn Andersson
2 siblings, 2 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2025-02-19 9:07 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, linux-arm-msm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
There should be exactly one space before and after '=', and one space
before '{'. No functional impact. Verified with comparing decompiled
DTB (dtx_diff and fdtdump+diff).
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/ipq9574.dtsi | 40 +++++++++----------
.../boot/dts/qcom/msm8917-xiaomi-riva.dts | 2 +-
arch/arm64/boot/dts/qcom/msm8917.dtsi | 2 +-
arch/arm64/boot/dts/qcom/qcs615.dtsi | 16 ++++----
arch/arm64/boot/dts/qcom/sm8750.dtsi | 2 +-
5 files changed, 31 insertions(+), 31 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/ipq9574.dtsi b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
index 942290028972..cac58352182e 100644
--- a/arch/arm64/boot/dts/qcom/ipq9574.dtsi
+++ b/arch/arm64/boot/dts/qcom/ipq9574.dtsi
@@ -876,11 +876,11 @@ frame@b128000 {
pcie1: pcie@10000000 {
compatible = "qcom,pcie-ipq9574";
- reg = <0x10000000 0xf1d>,
- <0x10000f20 0xa8>,
- <0x10001000 0x1000>,
- <0x000f8000 0x4000>,
- <0x10100000 0x1000>;
+ reg = <0x10000000 0xf1d>,
+ <0x10000f20 0xa8>,
+ <0x10001000 0x1000>,
+ <0x000f8000 0x4000>,
+ <0x10100000 0x1000>;
reg-names = "dbi", "elbi", "atu", "parf", "config";
device_type = "pci";
linux,pci-domain = <1>;
@@ -956,11 +956,11 @@ pcie1: pcie@10000000 {
pcie3: pcie@18000000 {
compatible = "qcom,pcie-ipq9574";
- reg = <0x18000000 0xf1d>,
- <0x18000f20 0xa8>,
- <0x18001000 0x1000>,
- <0x000f0000 0x4000>,
- <0x18100000 0x1000>;
+ reg = <0x18000000 0xf1d>,
+ <0x18000f20 0xa8>,
+ <0x18001000 0x1000>,
+ <0x000f0000 0x4000>,
+ <0x18100000 0x1000>;
reg-names = "dbi", "elbi", "atu", "parf", "config";
device_type = "pci";
linux,pci-domain = <3>;
@@ -1036,11 +1036,11 @@ pcie3: pcie@18000000 {
pcie2: pcie@20000000 {
compatible = "qcom,pcie-ipq9574";
- reg = <0x20000000 0xf1d>,
- <0x20000f20 0xa8>,
- <0x20001000 0x1000>,
- <0x00088000 0x4000>,
- <0x20100000 0x1000>;
+ reg = <0x20000000 0xf1d>,
+ <0x20000f20 0xa8>,
+ <0x20001000 0x1000>,
+ <0x00088000 0x4000>,
+ <0x20100000 0x1000>;
reg-names = "dbi", "elbi", "atu", "parf", "config";
device_type = "pci";
linux,pci-domain = <2>;
@@ -1116,11 +1116,11 @@ pcie2: pcie@20000000 {
pcie0: pci@28000000 {
compatible = "qcom,pcie-ipq9574";
- reg = <0x28000000 0xf1d>,
- <0x28000f20 0xa8>,
- <0x28001000 0x1000>,
- <0x00080000 0x4000>,
- <0x28100000 0x1000>;
+ reg = <0x28000000 0xf1d>,
+ <0x28000f20 0xa8>,
+ <0x28001000 0x1000>,
+ <0x00080000 0x4000>,
+ <0x28100000 0x1000>;
reg-names = "dbi", "elbi", "atu", "parf", "config";
device_type = "pci";
linux,pci-domain = <0>;
diff --git a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
index f1d22535fedd..df135f9891a8 100644
--- a/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
+++ b/arch/arm64/boot/dts/qcom/msm8917-xiaomi-riva.dts
@@ -119,7 +119,7 @@ bq27426@55 {
monitored-battery = <&battery>;
};
- bq25601@6b{
+ bq25601@6b {
compatible = "ti,bq25601";
reg = <0x6b>;
interrupts-extended = <&tlmm 61 IRQ_TYPE_EDGE_FALLING>;
diff --git a/arch/arm64/boot/dts/qcom/msm8917.dtsi b/arch/arm64/boot/dts/qcom/msm8917.dtsi
index 7bf58dd0146e..9d8358745c91 100644
--- a/arch/arm64/boot/dts/qcom/msm8917.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8917.dtsi
@@ -587,7 +587,7 @@ tsens_s4_p2: s4-p2@217 {
bits = <1 6>;
};
- tsens_s9_p1: s9-p1@230{
+ tsens_s9_p1: s9-p1@230 {
reg = <0x230 1>;
bits = <0 6>;
};
diff --git a/arch/arm64/boot/dts/qcom/qcs615.dtsi b/arch/arm64/boot/dts/qcom/qcs615.dtsi
index f4abfad474ea..6c17860dd6c8 100644
--- a/arch/arm64/boot/dts/qcom/qcs615.dtsi
+++ b/arch/arm64/boot/dts/qcom/qcs615.dtsi
@@ -1819,7 +1819,7 @@ replicator@6046000 {
in-ports {
port {
replicator0_in: endpoint {
- remote-endpoint= <&tmc_etf_out>;
+ remote-endpoint = <&tmc_etf_out>;
};
};
};
@@ -1832,7 +1832,7 @@ port@1 {
reg = <1>;
replicator0_out1: endpoint {
- remote-endpoint= <&replicator1_in>;
+ remote-endpoint = <&replicator1_in>;
};
};
};
@@ -1872,7 +1872,7 @@ replicator@604a000 {
in-ports {
port {
replicator1_in: endpoint {
- remote-endpoint= <&replicator0_out1>;
+ remote-endpoint = <&replicator0_out1>;
};
};
};
@@ -1880,7 +1880,7 @@ replicator1_in: endpoint {
out-ports {
port {
replicator1_out: endpoint {
- remote-endpoint= <&funnel_swao_in6>;
+ remote-endpoint = <&funnel_swao_in6>;
};
};
};
@@ -2311,7 +2311,7 @@ port@6 {
reg = <6>;
funnel_swao_in6: endpoint {
- remote-endpoint= <&replicator1_out>;
+ remote-endpoint = <&replicator1_out>;
};
};
@@ -2319,7 +2319,7 @@ port@7 {
reg = <7>;
funnel_swao_in7: endpoint {
- remote-endpoint= <&tpda_swao_out>;
+ remote-endpoint = <&tpda_swao_out>;
};
};
};
@@ -2343,7 +2343,7 @@ tmc@6b09000 {
in-ports {
port {
tmc_etf_swao_in: endpoint {
- remote-endpoint= <&funnel_swao_out>;
+ remote-endpoint = <&funnel_swao_out>;
};
};
};
@@ -2351,7 +2351,7 @@ tmc_etf_swao_in: endpoint {
out-ports {
port {
tmc_etf_swao_out: endpoint {
- remote-endpoint= <&replicator_swao_in>;
+ remote-endpoint = <&replicator_swao_in>;
};
};
};
diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
index abb92c81c76b..f81a3c3ae334 100644
--- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
@@ -990,7 +990,7 @@ uart14: serial@898000 {
clocks = <&gcc GCC_QUPV3_WRAP2_S5_CLK>;
clock-names = "se";
- interconnects = <&clk_virt MASTER_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS
+ interconnects = <&clk_virt MASTER_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS
&clk_virt SLAVE_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS>,
<&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS
&config_noc SLAVE_QUP_2 QCOM_ICC_TAG_ALWAYS>;
--
2.43.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: qcom: sm8750: Change labels to lower-case
2025-02-19 9:07 [PATCH 1/2] arm64: dts: qcom: sm8750: Change labels to lower-case Krzysztof Kozlowski
2025-02-19 9:07 ` [PATCH 2/2] arm64: dts: qcom: Corret white-space style Krzysztof Kozlowski
@ 2025-02-19 9:11 ` Konrad Dybcio
2025-03-04 17:00 ` (subset) " Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2025-02-19 9:11 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On 19.02.2025 10:07 AM, Krzysztof Kozlowski wrote:
> DTS coding style expects labels to be lowercase. No functional impact.
> Verified with comparing decompiled DTB (dtx_diff and fdtdump+diff).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: Corret white-space style
2025-02-19 9:07 ` [PATCH 2/2] arm64: dts: qcom: Corret white-space style Krzysztof Kozlowski
@ 2025-02-19 9:14 ` Konrad Dybcio
2025-02-20 12:23 ` Markus Elfring
1 sibling, 0 replies; 6+ messages in thread
From: Konrad Dybcio @ 2025-02-19 9:14 UTC (permalink / raw)
To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, linux-arm-msm, devicetree,
linux-kernel
On 19.02.2025 10:07 AM, Krzysztof Kozlowski wrote:
> There should be exactly one space before and after '=', and one space
> before '{'. No functional impact. Verified with comparing decompiled
> DTB (dtx_diff and fdtdump+diff).
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
> diff --git a/arch/arm64/boot/dts/qcom/sm8750.dtsi b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> index abb92c81c76b..f81a3c3ae334 100644
> --- a/arch/arm64/boot/dts/qcom/sm8750.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8750.dtsi
> @@ -990,7 +990,7 @@ uart14: serial@898000 {
> clocks = <&gcc GCC_QUPV3_WRAP2_S5_CLK>;
> clock-names = "se";
>
> - interconnects = <&clk_virt MASTER_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS
> + interconnects = <&clk_virt MASTER_QUP_CORE_2 QCOM_ICC_TAG_ALWAYS
for those wondering, there's a \t after '=' that becomes a space
Konrad
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: qcom: Corret white-space style
2025-02-19 9:07 ` [PATCH 2/2] arm64: dts: qcom: Corret white-space style Krzysztof Kozlowski
2025-02-19 9:14 ` Konrad Dybcio
@ 2025-02-20 12:23 ` Markus Elfring
1 sibling, 0 replies; 6+ messages in thread
From: Markus Elfring @ 2025-02-20 12:23 UTC (permalink / raw)
To: Krzysztof Kozlowski, devicetree, linux-arm-msm, Bjorn Andersson,
Conor Dooley, Konrad Dybcio, Rob Herring
Cc: Krzysztof Kozlowski, LKML
Please avoid a typo in the summary phrase.
Regards,
Markus
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: (subset) [PATCH 1/2] arm64: dts: qcom: sm8750: Change labels to lower-case
2025-02-19 9:07 [PATCH 1/2] arm64: dts: qcom: sm8750: Change labels to lower-case Krzysztof Kozlowski
2025-02-19 9:07 ` [PATCH 2/2] arm64: dts: qcom: Corret white-space style Krzysztof Kozlowski
2025-02-19 9:11 ` [PATCH 1/2] arm64: dts: qcom: sm8750: Change labels to lower-case Konrad Dybcio
@ 2025-03-04 17:00 ` Bjorn Andersson
2 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2025-03-04 17:00 UTC (permalink / raw)
To: Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
linux-arm-msm, devicetree, linux-kernel, Krzysztof Kozlowski
On Wed, 19 Feb 2025 10:07:50 +0100, Krzysztof Kozlowski wrote:
> DTS coding style expects labels to be lowercase. No functional impact.
> Verified with comparing decompiled DTB (dtx_diff and fdtdump+diff).
>
>
Applied, thanks!
[1/2] arm64: dts: qcom: sm8750: Change labels to lower-case
commit: 91e3ac15523fda23f5429d641248ab31b0d46fe7
[2/2] arm64: dts: qcom: Corret white-space style
commit: 27fd3266e8bd615af8ec5e91addac0b1dedc0b29
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2025-03-04 17:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-02-19 9:07 [PATCH 1/2] arm64: dts: qcom: sm8750: Change labels to lower-case Krzysztof Kozlowski
2025-02-19 9:07 ` [PATCH 2/2] arm64: dts: qcom: Corret white-space style Krzysztof Kozlowski
2025-02-19 9:14 ` Konrad Dybcio
2025-02-20 12:23 ` Markus Elfring
2025-02-19 9:11 ` [PATCH 1/2] arm64: dts: qcom: sm8750: Change labels to lower-case Konrad Dybcio
2025-03-04 17:00 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®