mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Christian Marangi <ansuelsmth@gmail.com>
Cc: Andy Whitcroft <apw@canonical.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] checkpatch: report warning with files ending with blank lines
Date: Wed, 07 Oct 2026 11:30:20 -0700	[thread overview]
Message-ID: <3e05a868415881335dec29a5d73f7994393f7409.camel@perches.com> (raw)
In-Reply-To: <6ac6876f.31081df4.3ada42.ff1e@mx.google.com>

On Wed, 2026-10-07 at 19:54 +0200, Christian Marangi wrote:
> Yes if you think about this, this will read the last line of the .patch,
> not the last line of a new file that will be generated by the .patch.
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 70a11f2ff61d..0b9946c532af 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -785,3 +785,9 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/spi/airoha,en7581-snand.yaml
>  F:	drivers/spi/spi-airoha-snfi.c
>  
> +AIROHA USB PHY DRIVER
> +M:	Christian Marangi <[ansuelsmth@gmail.com](mailto:ansuelsmth@gmail.com)>
> +L:	[linux-arm-kernel@lists.infradead.org](mailto:linux-arm-kernel@lists.infradead.org) (moderated for non-subscribers)
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/phy/airoha,an7581-usb-phy.yaml
> +
> -- 
> 2.55.0
> 
> It's to catch situation like this. Example for entire new file or adding
> stuff at the end of a file, where a new line is introduced.
> 
> git am will complain about this.

It seems there's something odd about the patch content
as there aren't any context lines after the addition.

How was it generated ?

  reply	other threads:[~2026-10-07 18:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 12:28 Christian Marangi
2026-10-07 16:49 ` Joe Perches
2026-10-07 16:52   ` Christian Marangi
2026-10-07 17:50     ` Joe Perches
2026-10-07 17:54       ` Christian Marangi
2026-10-07 18:30         ` Joe Perches [this message]
2026-10-07 18:31           ` Christian Marangi
2026-10-07 18:48             ` Joe Perches
2026-10-07 18:50               ` Christian Marangi (Ansuel)
2026-10-07 17:58     ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e05a868415881335dec29a5d73f7994393f7409.camel@perches.com \
    --to=joe@perches.com \
    --cc=ansuelsmth@gmail.com \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®