From: Joe Perches <joe@perches.com>
To: Christian Marangi <ansuelsmth@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] checkpatch: report warning with files ending with blank lines
Date: Wed, 07 Oct 2026 09:49:48 -0700 [thread overview]
Message-ID: <e8ef6959a0cb7093cfe4933da99fdfb5567f5354.camel@perches.com> (raw)
In-Reply-To: <20261007122837.2995-1-ansuelsmth@gmail.com>
On Wed, 2026-10-07 at 14:28 +0200, Christian Marangi wrote:
> ```
> On applying patch, git, depending on the default configuration, might
> complain for any file having blank lines at end of file.
I was not clear enough in my first reply.
I meant that the test should be done only once, not
for each line of the input.
After the end of the process() loop of
foreach my $rawline (@rawlines) {
[...]
}
a single test of $rawlines[-1] could be done.
next prev parent reply other threads:[~2026-10-07 16:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 12:28 Christian Marangi
2026-10-07 16:49 ` Joe Perches [this message]
2026-10-07 16:52 ` Christian Marangi
2026-10-07 17:50 ` Joe Perches
2026-10-07 17:54 ` Christian Marangi
2026-10-07 18:30 ` Joe Perches
2026-10-07 18:31 ` Christian Marangi
2026-10-07 18:48 ` Joe Perches
2026-10-07 18:50 ` Christian Marangi (Ansuel)
2026-10-07 17:58 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8ef6959a0cb7093cfe4933da99fdfb5567f5354.camel@perches.com \
--to=joe@perches.com \
--cc=ansuelsmth@gmail.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®