From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
Masami Hiramatsu <mhiramat@kernel.org>
Cc: soc@kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] arm64: dts: uniphier: Add NX1 SoC and boards support
Date: Fri, 4 Nov 2022 14:57:40 +0900 [thread overview]
Message-ID: <3e0a7894-677d-33fc-6b3c-a7561e18a93b@socionext.com> (raw)
In-Reply-To: <f1b5e138-e708-8aeb-9b59-96403f996fbd@linaro.org>
On 2022/11/03 1:48, Krzysztof Kozlowski wrote:
> On 01/11/2022 05:02, Kunihiko Hayashi wrote:
>> Hi Krzysztof,
>>
>
>
>>>> + compatible = "socionext,uniphier-nx1-clock";
>>>> + #clock-cells = <1>;
>>>> + };
>>>> +
>>>> + sys_rst: reset {
>>>
>>> reset-controller
>>>
>>>> + compatible = "socionext,uniphier-nx1-reset";
>>>> + #reset-cells = <1>;
>>>> + };
>>>> +
>>>> + watchdog {
>>>> + compatible = "socionext,uniphier-wdt";
>>>> + };
>>>> +
>>>> + pvtctl: thermal-sensor {
>>>> + compatible = "socionext,uniphier-nx1-thermal";
>>>> + interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
>>>> + #thermal-sensor-cells = <0>;
>>>> + socionext,tmod-calibration = <0x0f22 0x68ee>;
>>>> + };
>>>> + };
>>>> +
>>>> + spi0: spi@14006000 {
>>>> + compatible = "socionext,uniphier-scssi";
>>>> + status = "disabled";
>>>> + reg = <0x14006000 0x100>;
>>>
>>> Reg is second property. Status goes last. The same in other nodes.
>>
>> Hmm, I've put "status" here according to the existing (uniphier's) DT
>> policy
>> and this should rewrite the policy. Is there documentation somewhere that
>> recommends the order? Or, should I refer to previous comments?
>
> Hm, your decision (as arch maintainer) is then preferred, not mine.
> Although it is quite unusual to find status, not reg, as the second
> property.
Okay, however, if there are no examples where the second is "status",
I think it is better to follow the many descriptions for new additions.
> compatible followed by reg is not documented anywhere, it's just the
> most used style. And actually most sensible as it answers to questions
> from highest importance to lowest:
> 1. What is this device? compatible
> 2. Where is it? Does it match unit address? reg
> 3. all other properties
> 4. Is it off or on? status as optional property
I think it is reasonable to arrange the properties in order of importance.
I'll put "reg" second in this addition in the next.
Thank you,
---
Best Regards
Kunihiko Hayashi
prev parent reply other threads:[~2022-11-04 5:58 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 4:51 [PATCH 0/4] Add UniPhier " Kunihiko Hayashi
2022-10-27 4:51 ` [PATCH 1/4] dt-bindings: arm: uniphier: Add Pro5 boards Kunihiko Hayashi
2022-10-27 13:28 ` Krzysztof Kozlowski
2022-10-27 4:51 ` [PATCH 2/4] ARM: dts: uniphier: Add Pro5 board support Kunihiko Hayashi
2022-10-27 4:51 ` [PATCH 3/4] dt-bindings: arm: uniphier: Add NX1 boards Kunihiko Hayashi
2022-10-27 13:29 ` Krzysztof Kozlowski
2022-10-27 4:51 ` [PATCH 4/4] arm64: dts: uniphier: Add NX1 SoC and boards support Kunihiko Hayashi
2022-10-27 10:01 ` Arnd Bergmann
2022-10-27 11:19 ` Kunihiko Hayashi
2022-10-27 11:28 ` Arnd Bergmann
2022-10-27 11:58 ` Kunihiko Hayashi
2022-10-27 12:19 ` Arnd Bergmann
2022-10-27 13:36 ` Krzysztof Kozlowski
2022-11-01 9:02 ` Kunihiko Hayashi
2022-11-02 16:48 ` Krzysztof Kozlowski
2022-11-04 5:57 ` Kunihiko Hayashi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e0a7894-677d-33fc-6b3c-a7561e18a93b@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®