Re: [PATCH 2/2] clk: qcom: videocc-glymur: Add video clock controller driver for Glymur

[Taniya Das <taniya.das@oss.qualcomm.com>]

On 1/25/2026 1:52 AM, Dmitry Baryshkov wrote:
> On Sat, Jan 24, 2026 at 11:05:03PM +0530, Taniya Das wrote:
>> Add support for the video clock controller for video clients to be able
>> to request for videocc clocks on Glymur platform.
>>
>> Signed-off-by: Taniya Das <taniya.das@oss.qualcomm.com>
>> ---
>>  drivers/clk/qcom/Kconfig          |   9 +
>>  drivers/clk/qcom/Makefile         |   1 +
>>  drivers/clk/qcom/gcc-glymur.c     |   1 +
>>  drivers/clk/qcom/videocc-glymur.c | 526 ++++++++++++++++++++++++++++++++++++++
>>  4 files changed, 537 insertions(+)
>>
>> diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
>> index a8a86ea6bb7445e396048a5bba23fce8d719281f..20af4340b08f98773eadcc4a97b1669f51277eb8 100644
>> --- a/drivers/clk/qcom/Kconfig
>> +++ b/drivers/clk/qcom/Kconfig
>> @@ -46,6 +46,15 @@ config CLK_GLYMUR_TCSRCC
>>  	  Support for the TCSR clock controller on GLYMUR devices.
>>  	  Say Y if you want to use peripheral devices such as USB/PCIe/EDP.
>>  
>> +config CLK_GLYMUR_VIDEOCC
>> +	tristate "Glymur Video Clock Controller"
>> +	depends on ARM64 || COMPILE_TEST
>> +	select CLK_GLYMUR_GCC
>> +	help
>> +	  Support for the video clock controller on Glymur devices.
>> +	  Say Y if you want to support video devices and functionality such as
>> +	  video encode and decode.
>> +
>>  config CLK_KAANAPALI_CAMCC
>>  	tristate "Kaanapali Camera Clock Controller"
>>  	depends on ARM64 || COMPILE_TEST
>> diff --git a/drivers/clk/qcom/Makefile b/drivers/clk/qcom/Makefile
>> index 6b0ad8832b55f1914079f15323b8cdd1608ad4c0..a71dfd0ddf5122d91b5ab4427a9e36cdd57f7bbd 100644
>> --- a/drivers/clk/qcom/Makefile
>> +++ b/drivers/clk/qcom/Makefile
>> @@ -24,6 +24,7 @@ obj-$(CONFIG_CLK_GFM_LPASS_SM8250) += lpass-gfm-sm8250.o
>>  obj-$(CONFIG_CLK_GLYMUR_DISPCC) += dispcc-glymur.o
>>  obj-$(CONFIG_CLK_GLYMUR_GCC) += gcc-glymur.o
>>  obj-$(CONFIG_CLK_GLYMUR_TCSRCC) += tcsrcc-glymur.o
>> +obj-$(CONFIG_CLK_GLYMUR_VIDEOCC) += videocc-glymur.o
>>  obj-$(CONFIG_CLK_KAANAPALI_CAMCC) += cambistmclkcc-kaanapali.o camcc-kaanapali.o
>>  obj-$(CONFIG_CLK_KAANAPALI_DISPCC) += dispcc-kaanapali.o
>>  obj-$(CONFIG_CLK_KAANAPALI_GCC) += gcc-kaanapali.o
>> diff --git a/drivers/clk/qcom/gcc-glymur.c b/drivers/clk/qcom/gcc-glymur.c
>> index 238e205735ed594618b8526651968a4f73b1104e..cd11470a75f3fec67c1c0cb7fb2b54a814cfaf65 100644
>> --- a/drivers/clk/qcom/gcc-glymur.c
>> +++ b/drivers/clk/qcom/gcc-glymur.c
>> @@ -8507,6 +8507,7 @@ static const struct qcom_reset_map gcc_glymur_resets[] = {
>>  	[GCC_VIDEO_AXI0_CLK_ARES] = { 0x3201c, 2 },
>>  	[GCC_VIDEO_AXI1_CLK_ARES] = { 0x32044, 2 },
>>  	[GCC_VIDEO_BCR] = { 0x32000 },
>> +	[GCC_VIDEO_AXI0C_CLK_ARES] = { 0x32030, 2 },
> 
> Separate commit, description, Fixes, etc.
> 

Sure, will split and add the fixes tag as required in the next patch.


>>  };
>>  
>>  static const struct clk_rcg_dfs_data gcc_dfs_clocks[] = {
>> diff --git a/drivers/clk/qcom/videocc-glymur.c b/drivers/clk/qcom/videocc-glymur.c
>> new file mode 100644
>> index 0000000000000000000000000000000000000000..a5045866982554ea46a9d75033537e7771df8fd9
>> --- /dev/null
>> +++ b/drivers/clk/qcom/videocc-glymur.c
> 
> This one LGTM.
> 

-- 
Thanks,
Taniya Das