* [PATCH] media: i2c: Fix pixel array positions in ov8865
@ 2022-02-03 21:23 Daniel Scally
2022-02-03 21:30 ` Daniel Scally
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Scally @ 2022-02-03 21:23 UTC (permalink / raw)
To: linux-kernel; +Cc: sakari.ailus, paul.kocialkowski, Jean-Michel Hautbois
The ov8865's datasheet gives the pixel array as 3296x2528, and the
active portion as the centre 3264x2448. This makes for a top offset
of 40 and a left offset of 16, not 32 and 80.
Fixes: acd25e220921 ("media: i2c: Add .get_selection() support to ov8865")
Reported-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
Signed-off-by: Daniel Scally <djrscally@gmail.com>
---
drivers/media/i2c/ov8865.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
index d9d016cfa9ac..53e21ae8e886 100644
--- a/drivers/media/i2c/ov8865.c
+++ b/drivers/media/i2c/ov8865.c
@@ -457,8 +457,8 @@
#define OV8865_NATIVE_WIDTH 3296
#define OV8865_NATIVE_HEIGHT 2528
-#define OV8865_ACTIVE_START_TOP 32
-#define OV8865_ACTIVE_START_LEFT 80
+#define OV8865_ACTIVE_START_TOP 40
+#define OV8865_ACTIVE_START_LEFT 16
#define OV8865_ACTIVE_WIDTH 3264
#define OV8865_ACTIVE_HEIGHT 2448
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] media: i2c: Fix pixel array positions in ov8865
2022-02-03 21:23 [PATCH] media: i2c: Fix pixel array positions in ov8865 Daniel Scally
@ 2022-02-03 21:30 ` Daniel Scally
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Scally @ 2022-02-03 21:30 UTC (permalink / raw)
To: linux-kernel; +Cc: sakari.ailus, paul.kocialkowski, Jean-Michel Hautbois
Sorry all, missed media...let me resend this.
On 03/02/2022 21:23, Daniel Scally wrote:
> The ov8865's datasheet gives the pixel array as 3296x2528, and the
> active portion as the centre 3264x2448. This makes for a top offset
> of 40 and a left offset of 16, not 32 and 80.
>
> Fixes: acd25e220921 ("media: i2c: Add .get_selection() support to ov8865")
>
> Reported-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
> Signed-off-by: Daniel Scally <djrscally@gmail.com>
> ---
> drivers/media/i2c/ov8865.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/i2c/ov8865.c b/drivers/media/i2c/ov8865.c
> index d9d016cfa9ac..53e21ae8e886 100644
> --- a/drivers/media/i2c/ov8865.c
> +++ b/drivers/media/i2c/ov8865.c
> @@ -457,8 +457,8 @@
>
> #define OV8865_NATIVE_WIDTH 3296
> #define OV8865_NATIVE_HEIGHT 2528
> -#define OV8865_ACTIVE_START_TOP 32
> -#define OV8865_ACTIVE_START_LEFT 80
> +#define OV8865_ACTIVE_START_TOP 40
> +#define OV8865_ACTIVE_START_LEFT 16
> #define OV8865_ACTIVE_WIDTH 3264
> #define OV8865_ACTIVE_HEIGHT 2448
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-03 21:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-03 21:23 [PATCH] media: i2c: Fix pixel array positions in ov8865 Daniel Scally
2022-02-03 21:30 ` Daniel Scally
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®