mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Justin Lai <justinlai0215@realtek.com>
Cc: "kuba@kernel.org" <kuba@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"edumazet@google.com" <edumazet@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next v3 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code
Date: Mon, 21 Aug 2023 19:21:37 +0200	[thread overview]
Message-ID: <3e5b2f0a-3661-4147-bc4e-784eecf41364@lunn.ch> (raw)
In-Reply-To: <4db3248874d64418b63fdf5c5e8a0f79@realtek.com>

> But I2C, SPI, MDIO are connected to the SoC through this chip's
> external pins, not on the PCIe bus.

Thanks, that was the information i was trying to get at.

> Actually, there is the other function in the PCIe GMAC(Multiple
> function) to manage the registers of Switch Core.  Should they be
> integrated into the MFD driver?

Can you cleanly attach another PCI driver to those functions?

You need to use an MFD when there is a single top level addressable
block of hardware which has multiple functions. Thank of an I2C
device, which has a single address on the bus, but multiple functions.
Access to that one address needs to be shared via multiple
drivers. The MFD framework provides the glue to share access to the
hardware.

However, PCI identification and addressing is more flexible. So long
as they are separate PCI functions, you should be able to load two
drivers and not have problems. Then you don't need an MFD.

	Andrew

  reply	other threads:[~2023-08-21 17:21 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-15 14:37 [PATCH net-next v3 0/2] Add Realtek automotive PCIe driver Justin Lai
2023-08-15 14:37 ` [PATCH net-next v3 1/2] net/ethernet/realtek: Add Realtek automotive PCIe driver code Justin Lai
2023-08-15 15:33   ` Andrew Lunn
2023-08-17  7:32     ` Justin Lai
2023-08-17 12:22       ` Andrew Lunn
2023-08-18 11:56         ` Justin Lai
2023-08-18 12:16           ` Andrew Lunn
2023-08-21  5:31             ` Justin Lai
2023-08-21 13:12               ` Andrew Lunn
2023-08-21 15:07                 ` Justin Lai
2023-08-21 17:21                   ` Andrew Lunn [this message]
2023-08-22  3:26                     ` Justin Lai
2023-08-17 15:53   ` Jakub Kicinski
2023-08-18  6:44     ` Justin Lai
2023-08-15 14:37 ` [PATCH net-next v3 2/2] MAINTAINERS: Add the rtase ethernet driver entry Justin Lai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3e5b2f0a-3661-4147-bc4e-784eecf41364@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=justinlai0215@realtek.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome