From: Dave Hansen <dave.hansen@intel.com>
To: Sohil Mehta <sohil.mehta@intel.com>,
"Nikunj A. Dadhania" <nikunj@amd.com>,
bp@alien8.de
Cc: tglx@kernel.org, mingo@redhat.com, kvm@vger.kernel.org,
dave.hansen@linux.intel.com, hpa@zytor.com, xin@zytor.com,
seanjc@google.com, pbonzini@redhat.com, x86@kernel.org,
jon.grimm@amd.com, stable@vger.kernel.org,
Tom Lendacky <thomas.lendacky@amd.com>,
linux-kernel@vger.kernel.org, andrew.cooper3@citrix.com
Subject: Re: [PATCH] x86/fred: Fix early boot failures on SEV-ES/SNP guests
Date: Thu, 19 Feb 2026 12:22:54 -0800 [thread overview]
Message-ID: <3e630286-880b-44e8-9d35-d46bc4744b2a@intel.com> (raw)
In-Reply-To: <f7595e7a-e956-426f-81cc-63d742330532@intel.com>
On 2/19/26 11:27, Sohil Mehta wrote:
> On 2/15/2026 9:16 PM, Nikunj A. Dadhania wrote:
>> @@ -502,7 +517,7 @@ void cr4_init(void)
>>
>> if (boot_cpu_has(X86_FEATURE_PCID))
>> cr4 |= X86_CR4_PCIDE;
>> - if (static_branch_likely(&cr_pinning))
>> + if (cr_pinning_enabled())
>> cr4 = (cr4 & ~cr4_pinned_mask) | cr4_pinned_bits;
>>
> Maybe I am missing something, but is there a reason to keep this check
> anymore?
>
> AFAIU, cr_pinning_enabled() will always be false during cr4_init().
> cr4_init() always happens during early bringup when the cpu is marked
> offline.
Yeah, that should be dead code now.
It wouldn't hurt to say:
WARN_ON_ONCE(cr_pinning_enabled());
to kinda document that this code doesn't work with CR pinning.
next prev parent reply other threads:[~2026-02-19 20:22 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-05 5:10 Nikunj A Dadhania
2026-02-05 5:55 ` Greg KH
2026-02-05 6:10 ` Nikunj A. Dadhania
2026-02-05 6:20 ` Greg KH
2026-02-05 15:50 ` Sean Christopherson
2026-02-05 15:58 ` Dave Hansen
2026-02-05 16:00 ` Greg KH
2026-02-05 5:56 ` Greg KH
2026-02-05 6:24 ` Nikunj A. Dadhania
2026-02-05 7:11 ` Xin Li
2026-02-05 8:54 ` Nikunj A. Dadhania
2026-02-05 14:34 ` Xin Li
2026-02-05 10:41 ` kernel test robot
2026-02-06 3:31 ` Nikunj A. Dadhania
2026-02-06 9:34 ` Xin Li
2026-02-05 12:24 ` kernel test robot
2026-02-05 12:35 ` kernel test robot
2026-02-05 16:10 ` Dave Hansen
2026-02-05 17:20 ` Dave Hansen
2026-02-05 17:39 ` Tom Lendacky
2026-02-06 12:38 ` Nikunj A. Dadhania
2026-02-16 5:16 ` Nikunj A. Dadhania
2026-02-16 17:10 ` Dave Hansen
2026-02-19 19:27 ` Sohil Mehta
2026-02-19 20:22 ` Dave Hansen [this message]
2026-02-19 20:50 ` Sohil Mehta
2026-02-05 17:39 ` H. Peter Anvin
2026-02-06 12:12 ` Nikunj A. Dadhania
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e630286-880b-44e8-9d35-d46bc4744b2a@intel.com \
--to=dave.hansen@intel.com \
--cc=andrew.cooper3@citrix.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jon.grimm@amd.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=sohil.mehta@intel.com \
--cc=stable@vger.kernel.org \
--cc=tglx@kernel.org \
--cc=thomas.lendacky@amd.com \
--cc=x86@kernel.org \
--cc=xin@zytor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®