Re: [PATCH] drm/amdkfd: Fix error code sign for EINVAL in svm_ioctl()

["Kuehling, Felix" <felix.kuehling@amd.com>]

On 2025-09-04 10:07, Alex Deucher wrote:
> Applied.  Thanks!

Thank you, Alex!


>
> Alex
>
> On Thu, Sep 4, 2025 at 8:54 AM Qianfeng Rong <rongqianfeng@vivo.com> wrote:
>> Use negative error code -EINVAL instead of positive EINVAL in the default
>> case of svm_ioctl() to conform to Linux kernel error code conventions.
>>
>> Fixes: 42de677f7999 ("drm/amdkfd: register svm range")
>> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
>> ---
>>   drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
>> index 521c14c7a789..68ba239b2e5d 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
>> @@ -4261,7 +4261,7 @@ svm_ioctl(struct kfd_process *p, enum kfd_ioctl_svm_op op, uint64_t start,
>>                  r = svm_range_get_attr(p, mm, start, size, nattrs, attrs);
>>                  break;
>>          default:
>> -               r = EINVAL;
>> +               r = -EINVAL;
>>                  break;
>>          }
>>
>> --
>> 2.34.1
>>