* [PATCH] drm/amdkfd: Fix error code sign for EINVAL in svm_ioctl()
@ 2025-09-04 12:36 Qianfeng Rong
2025-09-04 14:07 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Qianfeng Rong @ 2025-09-04 12:36 UTC (permalink / raw)
To: Felix Kuehling, Alex Deucher, Christian König, David Airlie,
Simona Vetter, Philip Yang, Alex Sierra, amd-gfx, dri-devel,
linux-kernel
Cc: Qianfeng Rong
Use negative error code -EINVAL instead of positive EINVAL in the default
case of svm_ioctl() to conform to Linux kernel error code conventions.
Fixes: 42de677f7999 ("drm/amdkfd: register svm range")
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 521c14c7a789..68ba239b2e5d 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -4261,7 +4261,7 @@ svm_ioctl(struct kfd_process *p, enum kfd_ioctl_svm_op op, uint64_t start,
r = svm_range_get_attr(p, mm, start, size, nattrs, attrs);
break;
default:
- r = EINVAL;
+ r = -EINVAL;
break;
}
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdkfd: Fix error code sign for EINVAL in svm_ioctl()
2025-09-04 12:36 [PATCH] drm/amdkfd: Fix error code sign for EINVAL in svm_ioctl() Qianfeng Rong
@ 2025-09-04 14:07 ` Alex Deucher
2025-09-04 18:58 ` Kuehling, Felix
0 siblings, 1 reply; 3+ messages in thread
From: Alex Deucher @ 2025-09-04 14:07 UTC (permalink / raw)
To: Qianfeng Rong
Cc: Felix Kuehling, Alex Deucher, Christian König, David Airlie,
Simona Vetter, Philip Yang, Alex Sierra, amd-gfx, dri-devel,
linux-kernel
Applied. Thanks!
Alex
On Thu, Sep 4, 2025 at 8:54 AM Qianfeng Rong <rongqianfeng@vivo.com> wrote:
>
> Use negative error code -EINVAL instead of positive EINVAL in the default
> case of svm_ioctl() to conform to Linux kernel error code conventions.
>
> Fixes: 42de677f7999 ("drm/amdkfd: register svm range")
> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> index 521c14c7a789..68ba239b2e5d 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
> @@ -4261,7 +4261,7 @@ svm_ioctl(struct kfd_process *p, enum kfd_ioctl_svm_op op, uint64_t start,
> r = svm_range_get_attr(p, mm, start, size, nattrs, attrs);
> break;
> default:
> - r = EINVAL;
> + r = -EINVAL;
> break;
> }
>
> --
> 2.34.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdkfd: Fix error code sign for EINVAL in svm_ioctl()
2025-09-04 14:07 ` Alex Deucher
@ 2025-09-04 18:58 ` Kuehling, Felix
0 siblings, 0 replies; 3+ messages in thread
From: Kuehling, Felix @ 2025-09-04 18:58 UTC (permalink / raw)
To: Alex Deucher, Qianfeng Rong
Cc: Alex Deucher, Christian König, David Airlie, Simona Vetter,
Philip Yang, Alex Sierra, amd-gfx, dri-devel, linux-kernel
On 2025-09-04 10:07, Alex Deucher wrote:
> Applied. Thanks!
Thank you, Alex!
>
> Alex
>
> On Thu, Sep 4, 2025 at 8:54 AM Qianfeng Rong <rongqianfeng@vivo.com> wrote:
>> Use negative error code -EINVAL instead of positive EINVAL in the default
>> case of svm_ioctl() to conform to Linux kernel error code conventions.
>>
>> Fixes: 42de677f7999 ("drm/amdkfd: register svm range")
>> Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
>> ---
>> drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
>> index 521c14c7a789..68ba239b2e5d 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
>> @@ -4261,7 +4261,7 @@ svm_ioctl(struct kfd_process *p, enum kfd_ioctl_svm_op op, uint64_t start,
>> r = svm_range_get_attr(p, mm, start, size, nattrs, attrs);
>> break;
>> default:
>> - r = EINVAL;
>> + r = -EINVAL;
>> break;
>> }
>>
>> --
>> 2.34.1
>>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-09-04 18:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-04 12:36 [PATCH] drm/amdkfd: Fix error code sign for EINVAL in svm_ioctl() Qianfeng Rong
2025-09-04 14:07 ` Alex Deucher
2025-09-04 18:58 ` Kuehling, Felix
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®