* [PATCH V1] accel/amdxdna: Switch to always use chained command
@ 2026-02-06 6:02 Lizhi Hou
2026-02-06 6:53 ` Karol Wachowski
2026-02-06 14:52 ` Mario Limonciello
0 siblings, 2 replies; 3+ messages in thread
From: Lizhi Hou @ 2026-02-06 6:02 UTC (permalink / raw)
To: ogabbay, quic_jhugo, dri-devel, maciej.falkowski
Cc: Lizhi Hou, linux-kernel, max.zhen, sonal.santan, mario.limonciello
Preempt commands are only supported when submitted as chained commands.
To ensure preempt support works consistently, always submit commands in
chained command format.
Set force_cmdlist to true so that single commands are filled using the
chained command layout, enabling correct handling of preempt commands.
Fixes: 3a0ff7b98af4 ("accel/amdxdna: Support preemption requests")
Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
---
drivers/accel/amdxdna/aie2_ctx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
index 37d05f2e986f..6378a0bc7b6e 100644
--- a/drivers/accel/amdxdna/aie2_ctx.c
+++ b/drivers/accel/amdxdna/aie2_ctx.c
@@ -23,9 +23,9 @@
#include "amdxdna_pci_drv.h"
#include "amdxdna_pm.h"
-static bool force_cmdlist;
+static bool force_cmdlist = true;
module_param(force_cmdlist, bool, 0600);
-MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default false)");
+MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default true)");
#define HWCTX_MAX_TIMEOUT 60000 /* milliseconds */
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V1] accel/amdxdna: Switch to always use chained command
2026-02-06 6:02 [PATCH V1] accel/amdxdna: Switch to always use chained command Lizhi Hou
@ 2026-02-06 6:53 ` Karol Wachowski
2026-02-06 14:52 ` Mario Limonciello
1 sibling, 0 replies; 3+ messages in thread
From: Karol Wachowski @ 2026-02-06 6:53 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel, maciej.falkowski
Cc: linux-kernel, max.zhen, sonal.santan, mario.limonciello
On 2/6/2026 7:02 AM, Lizhi Hou wrote:
> Preempt commands are only supported when submitted as chained commands.
> To ensure preempt support works consistently, always submit commands in
> chained command format.
>
> Set force_cmdlist to true so that single commands are filled using the
> chained command layout, enabling correct handling of preempt commands.
>
> Fixes: 3a0ff7b98af4 ("accel/amdxdna: Support preemption requests")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> ---
> drivers/accel/amdxdna/aie2_ctx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
> index 37d05f2e986f..6378a0bc7b6e 100644
> --- a/drivers/accel/amdxdna/aie2_ctx.c
> +++ b/drivers/accel/amdxdna/aie2_ctx.c
> @@ -23,9 +23,9 @@
> #include "amdxdna_pci_drv.h"
> #include "amdxdna_pm.h"
>
> -static bool force_cmdlist;
> +static bool force_cmdlist = true;
> module_param(force_cmdlist, bool, 0600);
> -MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default false)");
> +MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default true)");
>
> #define HWCTX_MAX_TIMEOUT 60000 /* milliseconds */
>
Reviewed-by: Karol Wachowski <karol.wachowski@linux.intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH V1] accel/amdxdna: Switch to always use chained command
2026-02-06 6:02 [PATCH V1] accel/amdxdna: Switch to always use chained command Lizhi Hou
2026-02-06 6:53 ` Karol Wachowski
@ 2026-02-06 14:52 ` Mario Limonciello
1 sibling, 0 replies; 3+ messages in thread
From: Mario Limonciello @ 2026-02-06 14:52 UTC (permalink / raw)
To: Lizhi Hou, ogabbay, quic_jhugo, dri-devel, maciej.falkowski
Cc: linux-kernel, max.zhen, sonal.santan
On 2/6/2026 12:02 AM, Lizhi Hou wrote:
> Preempt commands are only supported when submitted as chained commands.
> To ensure preempt support works consistently, always submit commands in
> chained command format.
>
> Set force_cmdlist to true so that single commands are filled using the
> chained command layout, enabling correct handling of preempt commands.
>
> Fixes: 3a0ff7b98af4 ("accel/amdxdna: Support preemption requests")
> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
> ---
> drivers/accel/amdxdna/aie2_ctx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
> index 37d05f2e986f..6378a0bc7b6e 100644
> --- a/drivers/accel/amdxdna/aie2_ctx.c
> +++ b/drivers/accel/amdxdna/aie2_ctx.c
> @@ -23,9 +23,9 @@
> #include "amdxdna_pci_drv.h"
> #include "amdxdna_pm.h"
>
> -static bool force_cmdlist;
> +static bool force_cmdlist = true;
> module_param(force_cmdlist, bool, 0600);
> -MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default false)");
> +MODULE_PARM_DESC(force_cmdlist, "Force use command list (Default true)");
>
> #define HWCTX_MAX_TIMEOUT 60000 /* milliseconds */
>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-02-06 14:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-06 6:02 [PATCH V1] accel/amdxdna: Switch to always use chained command Lizhi Hou
2026-02-06 6:53 ` Karol Wachowski
2026-02-06 14:52 ` Mario Limonciello
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®