From: Waiman Long <llong@redhat.com>
To: "Tejun Heo" <tj@kernel.org>, "Michal Koutný" <mkoutny@suse.com>
Cc: Waiman Long <llong@redhat.com>,
linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Chen Ridong <chenridong@huawei.com>
Subject: Re: [PATCH] cgroup/cpuset: Move procfs cpuset attribute under cgroup-v1.c
Date: Thu, 16 Jan 2025 14:15:00 -0500 [thread overview]
Message-ID: <3ebd4519-4699-47ff-901e-a3ce30e45bcd@redhat.com> (raw)
In-Reply-To: <Z4lA702nBSWNFQYm@slm.duckdns.org>
On 1/16/25 12:25 PM, Tejun Heo wrote:
> Hello,
>
> On Thu, Jan 16, 2025 at 03:05:32PM +0100, Michal Koutný wrote:
>> On Thu, Jan 16, 2025 at 08:40:56AM -0500, Waiman Long <llong@redhat.com> wrote:
>>> I do have some reservation in taking out /proc/<pid>/cpuset by default as
>>> CPUSETS_V1 is off by default. This may break some existing user scripts.
>> Cannot be /proc/$pid/cpuset declared a v1 feature?
>> Similar to cpuset fs (that is under CPUSETS_V1). If there's a breakage,
>> the user is not non-v1 ready and CPUSETS_V1 must be enabled.
> I think we can try given that the config is providing an exit path. After
> all, users who were depending on cpusets on v1 are in the same boat.
I am not totally against this, but I think we need to make the
relationship between the CPUSETS_V1 config and /proc/<pid>/cpuset file
more visible if we want to go this route. We should update the help text
of CPUSETS_V1 config entry to emphasize this.
Cheers,
Longman
next prev parent reply other threads:[~2025-01-16 19:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 9:56 Michal Koutný
2025-01-16 13:40 ` Waiman Long
2025-01-16 14:05 ` Michal Koutný
2025-01-16 17:25 ` Tejun Heo
2025-01-16 19:15 ` Waiman Long [this message]
2025-01-16 19:38 ` Tejun Heo
2025-01-17 10:44 ` [PATCH v2] " Michal Koutný
2025-01-17 14:39 ` Waiman Long
2025-01-17 16:08 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ebd4519-4699-47ff-901e-a3ce30e45bcd@redhat.com \
--to=llong@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=chenridong@huawei.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkoutny@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®