mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Matti Vaittinen" <mazziesaccount@gmail.com>,
	"Rodolfo Giometti" <giometti@enneenne.com>,
	"Marcelo Schmitt" <marcelo.schmitt@analog.com>,
	"Antoniu Miclaus" <antoniu.miclaus@analog.com>,
	"Angelo Dureghello" <adureghello@baylibre.com>,
	"Tobias Sperling" <tobias.sperling@softing.com>,
	"Eason Yang" <j2anfernee@gmail.com>,
	"Marilene Andrade Garcia" <marilene.agarcia@gmail.com>,
	"Cosmin Tanislav" <cosmin-gabriel.tanislav.xa@renesas.com>,
	duje@dujemihanovic.xyz, herve.codina@bootlin.com,
	thomas.petazzoni@bootlin.com, linux-iio@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc
Date: Wed, 4 Nov 2026 12:28:26 +0100	[thread overview]
Message-ID: <3ec7364a-3373-489e-99aa-38723a0f7b17@bootlin.com> (raw)
In-Reply-To: <20261031234848.00248ddd@jic23-hlaptop>

Hi Jonathan,

On 11/1/26 00:48, Jonathan Cameron wrote:
> On Fri, 30 Oct 2026 17:47:04 +0100
> Maxime Chevallier <maxime.chevallier@bootlin.com> wrote:
> 
>> Add a new driver for the TI TLA2528 ADC chip. It has 8 12-bit
>> channels, that can also be configured as 16-bit averaging channels.
>>
>> This is a very simple driver, allowing reading raw values for each
>> channel. GPIO mode isn't supported for now, as well as buffered mode and
>> the 16-bit averaging mode.
>>
>> Co-developed-by: Rodolfo Giometti <giometti@enneenne.com>
>> Signed-off-by: Rodolfo Giometti <giometti@enneenne.com>
>> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
> Hi Maxime
> 
> A couple of minor things inline.  At least one due to cleanup
> that happened tree wide in the last year.
> 

Thanks a lot for your reviews, I'll address those in V3, I don't have
any objections on them, it's all clear and straightforward :)

Same goes for Matti, Victor and Rodolfo's comments, I'll just keep the
Kconfig help message consistent with other drivers.

Thanks,

Maxime


  parent reply	other threads:[~2026-11-04 11:28 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-30 16:47 [PATCH v2 0/2] Add driver for the TI TLA2528 i2c ADC Maxime Chevallier
2026-10-30 16:47 ` [PATCH v2 1/2] dt-bindings: iio: adc: add Texas Instruments TLA2528 Maxime Chevallier
2026-10-30 18:34   ` Conor Dooley
2026-10-30 16:47 ` [PATCH v2 2/2] iio: adc: add driver for Texas Instruments TLA2528 adc Maxime Chevallier
2026-10-31 17:30   ` Victor Chernyakin
2026-10-31 23:48   ` Jonathan Cameron
2026-11-02  7:37     ` Rodolfo Giometti
2026-11-04 11:28     ` Maxime Chevallier [this message]
2026-11-02  7:22   ` Matti Vaittinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ec7364a-3373-489e-99aa-38723a0f7b17@bootlin.com \
    --to=maxime.chevallier@bootlin.com \
    --cc=adureghello@baylibre.com \
    --cc=andy@kernel.org \
    --cc=antoniu.miclaus@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=cosmin-gabriel.tanislav.xa@renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=duje@dujemihanovic.xyz \
    --cc=giometti@enneenne.com \
    --cc=herve.codina@bootlin.com \
    --cc=j2anfernee@gmail.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.schmitt@analog.com \
    --cc=marilene.agarcia@gmail.com \
    --cc=mazziesaccount@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=tobias.sperling@softing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®