From: 章辉 <zhanghui31@xiaomi.com>
To: Bart Van Assche <bvanassche@acm.org>,
"axboe@kernel.dk" <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
方翔 <fangxiang@xiaomi.com>, 王辉 <wanghui33@xiaomi.com>
Subject: Re: [External Mail]Re: [PATCH v3] block: move non sync requests complete flow to softirq
Date: Thu, 5 Sep 2024 03:05:09 +0000 [thread overview]
Message-ID: <3ef65dbf-6a75-45f5-b9e4-af2d6603c581@xiaomi.com> (raw)
In-Reply-To: <a2cb0302-b333-4cea-aaea-4a7bae7024a9@acm.org>
On 2024/9/5 1:22, Bart Van Assche wrote:
> On 9/3/24 8:35 PM, 章辉 wrote:
>> Does set rq_affinity to 2 mean QUEUE_FLAG_SAME_COMP?
>
> From block/blk-sysfs.c:
>
> if (val == 2) {
> blk_queue_flag_set(QUEUE_FLAG_SAME_COMP, q);
> blk_queue_flag_set(QUEUE_FLAG_SAME_FORCE, q);
> }
>
>> This seems to determine on which core the current request is
>> completed, rather than in the interrupt top or bottom half?
>
> That's correct. I suggested this because I was wondering whether
> spreading the I/O completion workload over more CPU cores would help?
>
> Thanks,
>
> Bart.
>
hi Bart,
Increasing the CPU frequency or directly binding the interrupt to the
big core processing will definitely help the end io processing delay,
depending on the system's requirements for IO response delay.
But it does not seem to conflict with this modification to put the
time-consuming operation in the lower half.
Thanks
Zhang
next prev parent reply other threads:[~2024-09-05 3:05 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 11:54 ZhangHui
2024-09-03 17:28 ` Bart Van Assche
2024-09-03 17:47 ` Jens Axboe
2024-09-04 3:35 ` [External Mail]Re: " 章辉
2024-09-04 17:22 ` Bart Van Assche
2024-09-05 3:05 ` 章辉 [this message]
2024-09-03 17:49 ` Jens Axboe
2024-09-04 3:25 ` [External Mail]Re: " 章辉
2024-09-04 4:29 ` Christoph Hellwig
2024-09-05 2:52 ` [External Mail]Re: " 章辉
2024-09-04 8:01 ` Ming Lei
2024-09-05 2:46 ` [External Mail]Re: " 章辉
2024-09-05 3:49 ` Ming Lei
2024-09-05 7:33 ` 章辉
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ef65dbf-6a75-45f5-b9e4-af2d6603c581@xiaomi.com \
--to=zhanghui31@xiaomi.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=fangxiang@xiaomi.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanghui33@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®