From: Jens Axboe <axboe@kernel.dk>
To: ZhangHui <zhanghui31@xiaomi.com>, bvanassche@acm.org
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] block: move non sync requests complete flow to softirq
Date: Tue, 3 Sep 2024 11:49:28 -0600 [thread overview]
Message-ID: <dd859c1b-40d0-4a10-a6af-0d7fae28da41@kernel.dk> (raw)
In-Reply-To: <20240903115437.42307-1-zhanghui31@xiaomi.com>
On 9/3/24 5:54 AM, ZhangHui wrote:
> From: zhanghui <zhanghui31@xiaomi.com>
>
> Currently, for a controller that supports multiple queues, like UFS4.0,
> the mq_ops->complete is executed in the interrupt top-half. Therefore,
> the file system's end io is executed during the request completion process,
> such as f2fs_write_end_io on smartphone.
>
> However, we found that the execution time of the file system end io
> is strongly related to the size of the bio and the processing speed
> of the CPU. Because the file system's end io will traverse every page
> in bio, this is a very time-consuming operation.
>
> We measured that the 80M bio write operation on the little CPU will
> cause the execution time of the top-half to be greater than 100ms.
> The CPU tick on a smartphone is only 4ms, which will undoubtedly affect
> scheduling efficiency.
The elephant in the room here is why an 80M completion takes 100 msec?
That seems... insane.
That aside, doing writes that big isn't great for latencies in general,
even if they are orders of magnitude smaller (as they should be). Maybe
this is solvable by just limiting the write size here.
But it really seems out of line for a write that size to take 100 msec
to process.
--
Jens Axboe
next prev parent reply other threads:[~2024-09-03 17:49 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 11:54 ZhangHui
2024-09-03 17:28 ` Bart Van Assche
2024-09-03 17:47 ` Jens Axboe
2024-09-04 3:35 ` [External Mail]Re: " 章辉
2024-09-04 17:22 ` Bart Van Assche
2024-09-05 3:05 ` 章辉
2024-09-03 17:49 ` Jens Axboe [this message]
2024-09-04 3:25 ` 章辉
2024-09-04 4:29 ` Christoph Hellwig
2024-09-05 2:52 ` [External Mail]Re: " 章辉
2024-09-04 8:01 ` Ming Lei
2024-09-05 2:46 ` [External Mail]Re: " 章辉
2024-09-05 3:49 ` Ming Lei
2024-09-05 7:33 ` 章辉
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd859c1b-40d0-4a10-a6af-0d7fae28da41@kernel.dk \
--to=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhanghui31@xiaomi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®