[PATCH v3 0/5] Reserve Timer Nodes to avoid clash with Remoteproc firmware

[PATCH v3 0/5] Reserve Timer Nodes to avoid clash with Remoteproc firmware

[Beleswar Padhi]

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. At the same time, if Linux probes the timers, some
instability is observed while booting remote cores. Therefore, change
the status of the timer nodes to "reserved" to avoid any clash. 

v3: Changelog:
* Udit
1) j7200: Updated commit message description to remove DSPs as the SoC does not
have one.
2) j722s: Updated the correct commit for "Fixes:" tag which introduced the bug.
3) For entire series, removed comment about timer usage by R5fs in the MCU
voltage domain as those are used by Device Manager firmware to get SoC
functional.

Link to v2:
https://lore.kernel.org/all/20240814104151.2038457-1-b-padhi@ti.com/

v2: Changelog:
- Split the changes into individual patches for each SoC to tag the
  correct offending commit for "Fixes:" tag.

* Udit
1) Add the correct clashing timer nodes for J7200 SoC.
2) Port these changes to board level dts files instead of SoC level dtsi files.

Link to v1:
https://lore.kernel.org/all/20240607105559.771080-1-b-padhi@ti.com/

Beleswar Padhi (5):
  arm64: dts: ti: k3-j7200: Change timer nodes status to reserved
  arm64: dts: ti: k3-j721e: Change timer nodes status to reserved
  arm64: dts: ti: k3-j721s2: Change timer nodes status to reserved
  arm64: dts: ti: k3-j784s4: Change timer nodes status to reserved
  arm64: dts: ti: k3-j722s: Change timer nodes status to reserved

 .../dts/ti/k3-j7200-common-proc-board.dts     | 13 ++++++
 .../dts/ti/k3-j721e-common-proc-board.dts     | 29 +++++++++++++
 .../dts/ti/k3-j721s2-common-proc-board.dts    | 25 +++++++++++
 arch/arm64/boot/dts/ti/k3-j722s-evm.dts       | 13 ++++++
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts      | 41 +++++++++++++++++++
 5 files changed, 121 insertions(+)

-- 
2.34.1

[PATCH v3 1/5] arm64: dts: ti: k3-j7200: Change timer nodes status to reserved

[Beleswar Padhi]

The remoteproc firmware of R5F in the MAIN voltage domain use timers.
Therefore, change the status of the timer nodes to "reserved" to avoid
any clash. Usage is described as below:

	+===================+==========================+
	|  Remoteproc node  |        Timer Node        |
	+===================+==========================+
	| main_r5fss0_core0 | main_timer0, main_timer2 |
	+-------------------+--------------------------+
	| main_r5fss0_core1 | main_timer1              |
	+-------------------+--------------------------+

Fixes: c8a28ed4837c ("arm64: dts: ti: k3-j7200: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 .../boot/dts/ti/k3-j7200-common-proc-board.dts      | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
index 6593c5da82c0..a65066bd7f09 100644
--- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
@@ -471,3 +471,16 @@ &main_mcan3 {
 	pinctrl-0 = <&main_mcan3_pins_default>;
 	phys = <&transceiver3>;
 };
+
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
-- 
2.34.1

[PATCH v3 2/5] arm64: dts: ti: k3-j721e: Change timer nodes status to reserved

[Beleswar Padhi]

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+==============+
	|  Remoteproc node  |  Timer Node  |
	+===================+==============+
	| main_r5fss0_core0 | main_timer12 |
	+-------------------+--------------+
	| main_r5fss0_core1 | main_timer13 |
	+-------------------+--------------+
	| main_r5fss1_core0 | main_timer14 |
	+-------------------+--------------+
	| main_r5fss1_core1 | main_timer15 |
	+-------------------+--------------+
	| c66_0             | main_timer0  |
	+-------------------+--------------+
	| c66_1             | main_timer1  |
	+-------------------+--------------+
	| c71_0             | main_timer2  |
	+-------------------+--------------+

Fixes: 7f209dd1267c ("arm64: dts: ti: k3-j721e: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 .../dts/ti/k3-j721e-common-proc-board.dts     | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
index 8230d53cd696..d7969122afd8 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
@@ -974,3 +974,32 @@ &main_mcan2 {
 	pinctrl-0 = <&main_mcan2_pins_default>;
 	phys = <&transceiver4>;
 };
+
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
+&main_timer12 {
+	status = "reserved";
+};
+
+&main_timer13 {
+	status = "reserved";
+};
+
+&main_timer14 {
+	status = "reserved";
+};
+
+&main_timer15 {
+	status = "reserved";
+};
-- 
2.34.1

[PATCH v3 3/5] arm64: dts: ti: k3-j721s2: Change timer nodes status to reserved

[Beleswar Padhi]

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+=============+
	|  Remoteproc node  | Timer Node  |
	+===================+=============+
	| main_r5fss0_core0 | main_timer2 |
	+-------------------+-------------+
	| main_r5fss0_core1 | main_timer3 |
	+-------------------+-------------+
	| main_r5fss1_core0 | main_timer4 |
	+-------------------+-------------+
	| main_r5fss1_core1 | main_timer5 |
	+-------------------+-------------+
	| c71_0             | main_timer0 |
	+-------------------+-------------+
	| c71_1             | main_timer1 |
	+-------------------+-------------+

Fixes: 835d04422f9d ("arm64: dts: ti: k3-j721s2: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 .../dts/ti/k3-j721s2-common-proc-board.dts    | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
index c5a0b7cbb14f..2903e15b8d3b 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-common-proc-board.dts
@@ -525,3 +525,28 @@ &main_mcan5 {
 	pinctrl-0 = <&main_mcan5_pins_default>;
 	phys = <&transceiver4>;
 };
+
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
+&main_timer3 {
+	status = "reserved";
+};
+
+&main_timer4 {
+	status = "reserved";
+};
+
+&main_timer5 {
+	status = "reserved";
+};
-- 
2.34.1

[PATCH v3 4/5] arm64: dts: ti: k3-j784s4: Change timer nodes status to reserved

[Beleswar Padhi]

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+=============+
	|  Remoteproc node  | Timer Node  |
	+===================+=============+
	| main_r5fss0_core0 | main_timer4 |
	+-------------------+-------------+
	| main_r5fss0_core1 | main_timer5 |
	+-------------------+-------------+
	| main_r5fss1_core0 | main_timer6 |
	+-------------------+-------------+
	| main_r5fss1_core1 | main_timer7 |
	+-------------------+-------------+
	| main_r5fss2_core0 | main_timer8 |
	+-------------------+-------------+
	| main_r5fss2_core1 | main_timer9 |
	+-------------------+-------------+
	| c71_0             | main_timer0 |
	+-------------------+-------------+
	| c71_1             | main_timer1 |
	+-------------------+-------------+
	| c71_2             | main_timer2 |
	+-------------------+-------------+
	| c71_3             | main_timer3 |
	+-------------------+-------------+

Fixes: 833377cf858b ("arm64: dts: ti: k3-j784s4: Add general purpose timers")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j784s4-evm.dts | 41 ++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
index ffa38f41679d..5e8bea3a5d82 100644
--- a/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j784s4-evm.dts
@@ -1050,6 +1050,47 @@ &main_cpsw1_port1 {
 	status = "okay";
 };
 
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
+
+&main_timer3 {
+	status = "reserved";
+};
+
+&main_timer4 {
+	status = "reserved";
+};
+
+&main_timer5 {
+	status = "reserved";
+};
+
+&main_timer6 {
+	status = "reserved";
+};
+
+&main_timer7 {
+	status = "reserved";
+};
+
+&main_timer8 {
+	status = "reserved";
+};
+
+&main_timer9 {
+	status = "reserved";
+};
+
 &mailbox0_cluster0 {
 	status = "okay";
 	interrupts = <436>;
-- 
2.34.1

[PATCH v3 5/5] arm64: dts: ti: k3-j722s: Change timer nodes status to reserved

[Beleswar Padhi]

The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
use timers. Therefore, change the status of the timer nodes to
"reserved" to avoid any clash. Usage is described as below:

	+===================+=============+
	|  Remoteproc Node  | Timer Node  |
	+===================+=============+
	| main_r5fss0_core0 | main_timer0 |
	+-------------------+-------------+
	| c7x_0             | main_timer1 |
	+-------------------+-------------+
	| c7x_1             | main_timer2 |
	+-------------------+-------------+

Fixes: 29075cc09f43 ("arm64: dts: ti: Introduce AM62P5 family of SoCs")
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
index dd3b5f7039d7..e03beb0b5aad 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
@@ -566,3 +566,16 @@ &mcasp1 {
 	       0 0 0 0
 	>;
 };
+
+/* Timers are used by Remoteproc firmware */
+&main_timer0 {
+	status = "reserved";
+};
+
+&main_timer1 {
+	status = "reserved";
+};
+
+&main_timer2 {
+	status = "reserved";
+};
-- 
2.34.1

Re: [PATCH v3 0/5] Reserve Timer Nodes to avoid clash with Remoteproc firmware

[Nishanth Menon]

On 13:09-20240816, Beleswar Padhi wrote:
> The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
> use timers. At the same time, if Linux probes the timers, some
> instability is observed while booting remote cores. Therefore, change
> the status of the timer nodes to "reserved" to avoid any clash. 
> 
> v3: Changelog:
> * Udit
> 1) j7200: Updated commit message description to remove DSPs as the SoC does not
> have one.
> 2) j722s: Updated the correct commit for "Fixes:" tag which introduced the bug.
> 3) For entire series, removed comment about timer usage by R5fs in the MCU
> voltage domain as those are used by Device Manager firmware to get SoC
> functional.
> 
> Link to v2:
> https://lore.kernel.org/all/20240814104151.2038457-1-b-padhi@ti.com/
> 
> v2: Changelog:
> - Split the changes into individual patches for each SoC to tag the
>   correct offending commit for "Fixes:" tag.
> 
> * Udit
> 1) Add the correct clashing timer nodes for J7200 SoC.
> 2) Port these changes to board level dts files instead of SoC level dtsi files.
> 
> Link to v1:
> https://lore.kernel.org/all/20240607105559.771080-1-b-padhi@ti.com/
> 
> Beleswar Padhi (5):
>   arm64: dts: ti: k3-j7200: Change timer nodes status to reserved
>   arm64: dts: ti: k3-j721e: Change timer nodes status to reserved
>   arm64: dts: ti: k3-j721s2: Change timer nodes status to reserved
>   arm64: dts: ti: k3-j784s4: Change timer nodes status to reserved
>   arm64: dts: ti: k3-j722s: Change timer nodes status to reserved

All patches: please fix your $subject. it looked initially like
you were fixing the default SoC behavior, but later I realized
you are fixing the evm solution.

Also while at this make sure the corresponding SK behaviors are in sync
correctly as well. if you think they do not need to be fixed, address
that comment in the cover-letter.

> 
>  .../dts/ti/k3-j7200-common-proc-board.dts     | 13 ++++++
>  .../dts/ti/k3-j721e-common-proc-board.dts     | 29 +++++++++++++
>  .../dts/ti/k3-j721s2-common-proc-board.dts    | 25 +++++++++++
>  arch/arm64/boot/dts/ti/k3-j722s-evm.dts       | 13 ++++++
>  arch/arm64/boot/dts/ti/k3-j784s4-evm.dts      | 41 +++++++++++++++++++
>  5 files changed, 121 insertions(+)
> 
> -- 
> 2.34.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

Re: [PATCH v3 5/5] arm64: dts: ti: k3-j722s: Change timer nodes status to reserved

[Kumar, Udit]

On 8/16/2024 1:09 PM, Beleswar Padhi wrote:
> The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
> use timers. Therefore, change the status of the timer nodes to
> "reserved" to avoid any clash. Usage is described as below:
>
> 	+===================+=============+
> 	|  Remoteproc Node  | Timer Node  |
> 	+===================+=============+
> 	| main_r5fss0_core0 | main_timer0 |
> 	+-------------------+-------------+
> 	| c7x_0             | main_timer1 |
> 	+-------------------+-------------+
> 	| c7x_1             | main_timer2 |
> 	+-------------------+-------------+
>
> Fixes: 29075cc09f43 ("arm64: dts: ti: Introduce AM62P5 family of SoCs")
> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
> ---
>   arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 13 +++++++++++++
>   1 file changed, 13 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> index dd3b5f7039d7..e03beb0b5aad 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> @@ -566,3 +566,16 @@ &mcasp1 {
>   	       0 0 0 0
>   	>;
>   };
> +
> +/* Timers are used by Remoteproc firmware */
> +&main_timer0 {
> +	status = "reserved";
> +};
> +
> +&main_timer1 {
> +	status = "reserved";
> +};
> +
> +&main_timer2 {
> +	status = "reserved";
> +};


Since IPC is not up-streamed for J722S , So I suggest to drop this patch 
from this series

and include this when you upstream IPC support for J722S board .

Re: [PATCH v3 0/5] Reserve Timer Nodes to avoid clash with Remoteproc firmware

[Beleswar Prasad Padhi]

On 24/08/24 23:33, Nishanth Menon wrote:
> On 13:09-20240816, Beleswar Padhi wrote:
>> The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
>> use timers. At the same time, if Linux probes the timers, some
>> instability is observed while booting remote cores. Therefore, change
>> the status of the timer nodes to "reserved" to avoid any clash.
>>
>> v3: Changelog:
>> * Udit
>> 1) j7200: Updated commit message description to remove DSPs as the SoC does not
>> have one.
>> 2) j722s: Updated the correct commit for "Fixes:" tag which introduced the bug.
>> 3) For entire series, removed comment about timer usage by R5fs in the MCU
>> voltage domain as those are used by Device Manager firmware to get SoC
>> functional.
>>
>> Link to v2:
>> https://lore.kernel.org/all/20240814104151.2038457-1-b-padhi@ti.com/
>>
>> v2: Changelog:
>> - Split the changes into individual patches for each SoC to tag the
>>    correct offending commit for "Fixes:" tag.
>>
>> * Udit
>> 1) Add the correct clashing timer nodes for J7200 SoC.
>> 2) Port these changes to board level dts files instead of SoC level dtsi files.
>>
>> Link to v1:
>> https://lore.kernel.org/all/20240607105559.771080-1-b-padhi@ti.com/
>>
>> Beleswar Padhi (5):
>>    arm64: dts: ti: k3-j7200: Change timer nodes status to reserved
>>    arm64: dts: ti: k3-j721e: Change timer nodes status to reserved
>>    arm64: dts: ti: k3-j721s2: Change timer nodes status to reserved
>>    arm64: dts: ti: k3-j784s4: Change timer nodes status to reserved
>>    arm64: dts: ti: k3-j722s: Change timer nodes status to reserved
> All patches: please fix your $subject. it looked initially like
Thanks for pointing out, fixed this in v4 revision.
> you were fixing the default SoC behavior, but later I realized
> you are fixing the evm solution.
>
> Also while at this make sure the corresponding SK behaviors are in sync
Thanks for catching this. I have included timer changes for SK boards in 
the v4 revision.
> correctly as well. if you think they do not need to be fixed, address
> that comment in the cover-letter.
>
>>   .../dts/ti/k3-j7200-common-proc-board.dts     | 13 ++++++
>>   .../dts/ti/k3-j721e-common-proc-board.dts     | 29 +++++++++++++
>>   .../dts/ti/k3-j721s2-common-proc-board.dts    | 25 +++++++++++
>>   arch/arm64/boot/dts/ti/k3-j722s-evm.dts       | 13 ++++++
>>   arch/arm64/boot/dts/ti/k3-j784s4-evm.dts      | 41 +++++++++++++++++++
>>   5 files changed, 121 insertions(+)
>>
>> -- 
>> 2.34.1
>>

Re: [PATCH v3 5/5] arm64: dts: ti: k3-j722s: Change timer nodes status to reserved

[Beleswar Prasad Padhi]

On 26/08/24 10:30, Kumar, Udit wrote:
>
> On 8/16/2024 1:09 PM, Beleswar Padhi wrote:
>> The remoteproc firmware like of R5F and DSPs in the MAIN voltage domain
>> use timers. Therefore, change the status of the timer nodes to
>> "reserved" to avoid any clash. Usage is described as below:
>>
>>     +===================+=============+
>>     |  Remoteproc Node  | Timer Node  |
>>     +===================+=============+
>>     | main_r5fss0_core0 | main_timer0 |
>>     +-------------------+-------------+
>>     | c7x_0             | main_timer1 |
>>     +-------------------+-------------+
>>     | c7x_1             | main_timer2 |
>>     +-------------------+-------------+
>>
>> Fixes: 29075cc09f43 ("arm64: dts: ti: Introduce AM62P5 family of SoCs")
>> Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
>> ---
>>   arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts 
>> b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> index dd3b5f7039d7..e03beb0b5aad 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> @@ -566,3 +566,16 @@ &mcasp1 {
>>              0 0 0 0
>>       >;
>>   };
>> +
>> +/* Timers are used by Remoteproc firmware */
>> +&main_timer0 {
>> +    status = "reserved";
>> +};
>> +
>> +&main_timer1 {
>> +    status = "reserved";
>> +};
>> +
>> +&main_timer2 {
>> +    status = "reserved";
>> +};
>
>
> Since IPC is not up-streamed for J722S , So I suggest to drop this 
> patch from this series
Thanks for catching this! I have dropped this patch in v4 revision of 
this series.
>
> and include this when you upstream IPC support for J722S board .
>
>