From: Javier Martinez Canillas <javier@osg.samsung.com>
To: Casey Schaufler <casey@schaufler-ca.com>, linux-kernel@vger.kernel.org
Cc: "Serge E. Hallyn" <serge@hallyn.com>,
Paul Moore <paul@paul-moore.com>,
linux-security-module@vger.kernel.org,
Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
selinux@tycho.nsa.gov, James Morris <james.l.morris@oracle.com>
Subject: Re: [PATCH] security: Use IS_ENABLED() instead of checking for built-in or module
Date: Thu, 14 Jul 2016 12:20:29 -0400 [thread overview]
Message-ID: <3f0053fa-8824-f86f-e04f-16ad1204abc7@osg.samsung.com> (raw)
In-Reply-To: <adc7dca8-9685-c9f0-7d61-d3537963cf6f@schaufler-ca.com>
Hello Casey,
On 07/14/2016 12:17 PM, Casey Schaufler wrote:
> On 7/14/2016 9:00 AM, Javier Martinez Canillas wrote:
>> The IS_ENABLED() macro checks if a Kconfig symbol has been enabled either
>> built-in or as a module, use that macro instead of open coding the same.
>
> Why?
>
Why not? We have a macro for this so why is better to open coding it?
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
next prev parent reply other threads:[~2016-07-14 16:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 16:00 Javier Martinez Canillas
2016-07-14 16:17 ` Casey Schaufler
2016-07-14 16:20 ` Javier Martinez Canillas [this message]
2016-07-14 16:30 ` Casey Schaufler
2016-07-14 19:57 ` Paul Moore
2016-07-14 20:54 ` Casey Schaufler
2016-07-14 22:06 ` Paul Moore
2016-07-15 11:39 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f0053fa-8824-f86f-e04f-16ad1204abc7@osg.samsung.com \
--to=javier@osg.samsung.com \
--cc=casey@schaufler-ca.com \
--cc=eparis@parisplace.org \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®