mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Matt Turner <mattst88@gmail.com>
Cc: Richard Henderson <richard.henderson@linaro.org>,
	Magnus Lindholm <linmag7@gmail.com>,
	linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH 5/7] hwmon: Add driver for Marvel AlphaServer environmental sensors
Date: Sat, 14 Nov 2026 19:46:53 -0800	[thread overview]
Message-ID: <3f6d66cf-8a1a-4074-a234-dfe571622aee@roeck-us.net> (raw)
In-Reply-To: <CAEdQ38GEckm8oU9pmg_t-_EC85brP4ghWAE4tYBNEvF+gcqMKA@mail.gmail.com>

On 11/14/26 18:50, Matt Turner wrote:
...
>>> +``in[0-*]_alarm``           Sensor is in the warning or fault state
>>
>> Which one is it ? Is it distinct ? A "fault" means
>> that the hardware is broken/defective. An alarm means that
>> the voltage is too high or too low. A faulty channel
>> should not be reported as alarm but as fault.
> 
> It is always the voltage being out of range: Warning is the reading
> outside the warning limits (5% from nominal), Failure outside the
> failure limits (10%). Both are reported as in_alarm in v2. The limits
> are not in the console's packet, so they are not exported.
> 

This could be reported as inX_max_alarm and inX_crit_alarm.

Thanks,
Guenter


  reply	other threads:[~2026-11-15  3:46 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-14 17:39 [PATCH 0/7] alpha: marvel: " Matt Turner
2026-11-14 17:39 ` [PATCH 1/7] alpha: marvel: report environmental events without VERBOSE_MCHECK Matt Turner
2026-11-14 23:01   ` Guenter Roeck
2026-11-15  2:43     ` Matt Turner
2026-11-14 17:39 ` [PATCH 2/7] alpha: marvel: fix the environmental subpacket layout Matt Turner
2026-11-14 17:39 ` [PATCH 3/7] alpha: marvel: refresh environmental readings through the console Matt Turner
2026-11-14 17:39 ` [PATCH 4/7] alpha: marvel: register a platform device for the environmental sensors Matt Turner
2026-11-14 17:39 ` [PATCH 5/7] hwmon: Add driver for Marvel AlphaServer " Matt Turner
2026-11-14 23:00   ` Guenter Roeck
2026-11-15  2:50     ` Matt Turner
2026-11-15  3:46       ` Guenter Roeck [this message]
2026-11-14 17:39 ` [PATCH 6/7] alpha: marvel: notify environmental events Matt Turner
2026-11-14 17:39 ` [PATCH 7/7] hwmon: (marvel-env) Notify userspace of " Matt Turner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f6d66cf-8a1a-4074-a234-dfe571622aee@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=linmag7@gmail.com \
    --cc=linux-alpha@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mattst88@gmail.com \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®