From: "Jaswinder Singh Rajput" <jaswinderlinux@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Jaswinder Singh Rajput" <jaswinder@infradead.org>,
"Alan Cox" <alan@lxorguk.ukuu.org.uk>,
"x86 maintainers" <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: mpparse.c fix style problems
Date: Sun, 4 Jan 2009 23:04:28 +0530 [thread overview]
Message-ID: <3f9a31f40901040934g5f48a2e0q332180ace15bedfe@mail.gmail.com> (raw)
In-Reply-To: <20090104172319.GA1238@elte.hu>
On Sun, Jan 4, 2009 at 10:53 PM, Ingo Molnar <mingo@elte.hu> wrote:
>>
>> Similarly in arch/x86/include/asm/io_apic.h :
>> 1. struct mp_config_ioapic with mp_X fields (what name will be best ?)
>> 2. struct mp_config_intsrc with mp_X fields
>>
>> These are also used in arch/x86/kernel/mpparse.c
>>
>> Please let me know should I fix mp_X things first or should I proceed
>> further in mpparse.c as per your suggestions.
>
> i think those should be standardized to mpc_X too, and the fields should
> lose their mp_ prefix.
>
Earlier we was having 2 sets :-
struct mpc_config_ioapic (mpspec) and mp_config_ioapic (ioapic)
struct mpc_config_intsrc (mpspec) and mp_config_intsrc (ioapic)
We moved struct mpc_config_X to struct mpc_X
I want to know what should be name for mp_config_ioapic. Is struct
mp_ioapic is OK ?
JSR
next prev parent reply other threads:[~2009-01-04 17:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 11:38 Jaswinder Singh Rajput
2009-01-02 17:21 ` Ingo Molnar
2009-01-02 17:51 ` Jaswinder Singh Rajput
2009-01-02 18:19 ` Jaswinder Singh Rajput
2009-01-04 17:17 ` Jaswinder Singh Rajput
2009-01-04 17:23 ` Ingo Molnar
2009-01-04 17:34 ` Jaswinder Singh Rajput [this message]
2009-01-08 14:43 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f9a31f40901040934g5f48a2e0q332180ace15bedfe@mail.gmail.com \
--to=jaswinderlinux@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®