From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: cjz <guagua210311@qq.com>, linux-staging@vger.kernel.org
Cc: gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] rtl8723bs: Add kernel-doc comment for rtw_reset_continual_io_error in rtw_io.c
Date: Wed, 17 Dec 2025 07:38:00 -0800 [thread overview]
Message-ID: <3fe689f9-c434-4c3c-a8cf-0b8ab65153c2@oss.qualcomm.com> (raw)
In-Reply-To: <tencent_BAB546E9C29DF17A0E3BCE8EAE1428D88206@qq.com>
On 12/13/2025 10:16 PM, cjz wrote:
> From: changjunzheng <guagua210311@qq.com>
>
> rtw_reset_continual_io_error lacks a standard kernel-doc comment and has an incorrect
> parameter name (dvobjprive vs dvobj) in the existing comment, which causes gcc W=1
> warning and reduces code readability.
>
> This change replaces the non-standard comment with a complete English kernel-doc comment,
> fixes the parameter name error, and keeps all functional logic unchanged.
In addition to Greg's comment, please also review:
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes
In particular:
Describe your changes in imperative mood, e.g. “make xyzzy do frotz” instead
of “[This patch] makes xyzzy do frotz” or “[I] changed xyzzy to do frotz”, as
if you are giving orders to the codebase to change its behaviour.
prev parent reply other threads:[~2025-12-17 15:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-14 6:16 cjz
2025-12-17 13:06 ` Greg KH
2025-12-17 15:38 ` Jeff Johnson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fe689f9-c434-4c3c-a8cf-0b8ab65153c2@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=guagua210311@qq.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®