From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Ankit Chauhan <ankitchauhan2065@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm: lanyang: fix lable->label typo for lanyang dts
Date: Thu, 12 Jun 2025 15:01:58 +0930 [thread overview]
Message-ID: <3fe9885cc54a328932915a63816ac1b7952689a2.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20250529-lanyang-lable-fix-v1-1-8a2dcb48bda4@gmail.com>
Hi Ankit, thanks for the fix.
Regarding the subject, can you please use the prefix 'ARM: dts:
aspeed:'? From there, I'd prefer something like:
ARM: dts: aspeed: lanyang: Fix 'lable' typo in LED nodes
On Thu, 2025-05-29 at 17:09 +0530, Ankit Chauhan wrote:
> Fix an obvious spelling error in the dts file for Lanyang BMC.
> This was reported by bugzilla a few years ago but never got fixed.
>
> Reported by: Jens Schleusener <Jens.Schleusener@fossies.org>
Please make sure these tags reflect convention:
https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
Rather than spaces, they use `-` to separate words, so:
Reported-by: ...
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=205891
>
> Signed-off-by: Ankit Chauhan <ankitchauhan2065@gmail.com>
Finally, all the tags should go together in the 'trailer' (final
paragraph). There should not be an empty line between the `Closes:` tag
and your `Signed-off-by:` tag above.
Cheers,
Andrew
next prev parent reply other threads:[~2025-06-12 5:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-29 11:39 Ankit Chauhan
2025-06-12 5:31 ` Andrew Jeffery [this message]
2025-06-12 7:06 ` Ankit Chauhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fe9885cc54a328932915a63816ac1b7952689a2.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=ankitchauhan2065@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®