* [PATCH] arm: lanyang: fix lable->label typo for lanyang dts
@ 2025-05-29 11:39 Ankit Chauhan
2025-06-12 5:31 ` Andrew Jeffery
0 siblings, 1 reply; 3+ messages in thread
From: Ankit Chauhan @ 2025-05-29 11:39 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
Andrew Jeffery
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel, Ankit Chauhan
Fix an obvious spelling error in the dts file for Lanyang BMC.
This was reported by bugzilla a few years ago but never got fixed.
Reported by: Jens Schleusener <Jens.Schleusener@fossies.org>
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=205891
Signed-off-by: Ankit Chauhan <ankitchauhan2065@gmail.com>
---
arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
index 370738572a55b2498fff31a4aabf336cc41e1eac..8b9d382241ff11329fcbaca5a469aebb11fd3460 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-opp-lanyang.dts
@@ -52,12 +52,12 @@ hdd_fault {
gpios = <&gpio ASPEED_GPIO(B, 3) GPIO_ACTIVE_HIGH>;
};
bmc_err {
- lable = "BMC_fault";
+ label = "BMC_fault";
gpios = <&gpio ASPEED_GPIO(H, 6) GPIO_ACTIVE_HIGH>;
};
sys_err {
- lable = "Sys_fault";
+ label = "Sys_fault";
gpios = <&gpio ASPEED_GPIO(H, 7) GPIO_ACTIVE_HIGH>;
};
};
---
base-commit: a5806cd506af5a7c19bcd596e4708b5c464bfd21
change-id: 20250529-lanyang-lable-fix-0e36bf4c4fd9
Best regards,
--
Ankit Chauhan <ankitchauhan2065@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: lanyang: fix lable->label typo for lanyang dts
2025-05-29 11:39 [PATCH] arm: lanyang: fix lable->label typo for lanyang dts Ankit Chauhan
@ 2025-06-12 5:31 ` Andrew Jeffery
2025-06-12 7:06 ` Ankit Chauhan
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Jeffery @ 2025-06-12 5:31 UTC (permalink / raw)
To: Ankit Chauhan, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Joel Stanley
Cc: devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
Hi Ankit, thanks for the fix.
Regarding the subject, can you please use the prefix 'ARM: dts:
aspeed:'? From there, I'd prefer something like:
ARM: dts: aspeed: lanyang: Fix 'lable' typo in LED nodes
On Thu, 2025-05-29 at 17:09 +0530, Ankit Chauhan wrote:
> Fix an obvious spelling error in the dts file for Lanyang BMC.
> This was reported by bugzilla a few years ago but never got fixed.
>
> Reported by: Jens Schleusener <Jens.Schleusener@fossies.org>
Please make sure these tags reflect convention:
https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
Rather than spaces, they use `-` to separate words, so:
Reported-by: ...
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=205891
>
> Signed-off-by: Ankit Chauhan <ankitchauhan2065@gmail.com>
Finally, all the tags should go together in the 'trailer' (final
paragraph). There should not be an empty line between the `Closes:` tag
and your `Signed-off-by:` tag above.
Cheers,
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] arm: lanyang: fix lable->label typo for lanyang dts
2025-06-12 5:31 ` Andrew Jeffery
@ 2025-06-12 7:06 ` Ankit Chauhan
0 siblings, 0 replies; 3+ messages in thread
From: Ankit Chauhan @ 2025-06-12 7:06 UTC (permalink / raw)
To: Andrew Jeffery
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Joel Stanley,
devicetree, linux-arm-kernel, linux-aspeed, linux-kernel
On Thu, Jun 12, 2025 at 03:01:58PM +0930, Andrew Jeffery wrote:
> Hi Ankit, thanks for the fix.
>
> Regarding the subject, can you please use the prefix 'ARM: dts:
> aspeed:'? From there, I'd prefer something like:
>
> ARM: dts: aspeed: lanyang: Fix 'lable' typo in LED nodes
>
> On Thu, 2025-05-29 at 17:09 +0530, Ankit Chauhan wrote:
> > Fix an obvious spelling error in the dts file for Lanyang BMC.
> > This was reported by bugzilla a few years ago but never got fixed.
> >
> > Reported by: Jens Schleusener <Jens.Schleusener@fossies.org>
>
> Please make sure these tags reflect convention:
>
> https://docs.kernel.org/process/submitting-patches.html#using-reported-by-tested-by-reviewed-by-suggested-by-and-fixes
>
> Rather than spaces, they use `-` to separate words, so:
>
> Reported-by: ...
>
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=205891
> >
> > Signed-off-by: Ankit Chauhan <ankitchauhan2065@gmail.com>
>
> Finally, all the tags should go together in the 'trailer' (final
> paragraph). There should not be an empty line between the `Closes:` tag
> and your `Signed-off-by:` tag above.
>
Hi Andrew,
Thanks for the feedback. I will make all the necessary changes and send
a v2 PATCH.
Kind regards,
Ankit Chauhan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-06-12 7:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-05-29 11:39 [PATCH] arm: lanyang: fix lable->label typo for lanyang dts Ankit Chauhan
2025-06-12 5:31 ` Andrew Jeffery
2025-06-12 7:06 ` Ankit Chauhan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®