mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Xin Li <xin@zytor.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: bp@alien8.de, brgerst@gmail.com, dave.hansen@linux.intel.com,
	ebiederm@xmission.com, hpa@zytor.com,
	linux-kernel@vger.kernel.org, mingo@redhat.com,
	tglx@linutronix.de, x86@kernel.org,
	Andy Lutomirski <luto@kernel.org>
Subject: Re: [PATCH v2 1/1] x86/ia32: Normalize any null selector value to 0
Date: Wed, 20 Nov 2024 19:54:54 -0800	[thread overview]
Message-ID: <3ff385ea-0b7a-441f-9905-4aad54c7575d@zytor.com> (raw)
In-Reply-To: <7b819c31-1972-44e0-87c7-1d11ac13f530@citrix.com>

On 11/20/2024 11:34 AM, Andrew Cooper wrote:
> On 20/11/2024 7:09 pm, Xin Li wrote:
>> On 11/20/2024 1:33 AM, Andrew Cooper wrote:
>>> Right now, this change is codifying the problem behaviour we were trying
>>> to fix out under FRED.
>>>
>>> Under FRED, if userspace loads e.g. 2 into a selector, it should remain
>>> 2 until userspace changes it to something else.
>>
>> Okay, I will fix it by:
>> 1) For null selector values, do nothing.
>> 2) For non-null selector values, set RPL bits.
>>
>> sounds okay?
> 
> Yeah, that sounds okay.

Actually this is what v1 does:

https://lore.kernel.org/lkml/20230706052231.2183-1-xin3.li@intel.com/

But obviously I need to rewrite the change log.

> 
> The selftest ought to work under FRED, but it was speculative coding.  I
> can't rule out that tweaks might be needed.

The v1 makes the test happy with both IDT and FRED.

Thanks!
     Xin


      reply	other threads:[~2024-11-21  3:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-20  8:17 Xin Li (Intel)
2024-11-20  9:33 ` Andrew Cooper
2024-11-20 19:09   ` Xin Li
2024-11-20 19:34     ` Andrew Cooper
2024-11-21  3:54       ` Xin Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ff385ea-0b7a-441f-9905-4aad54c7575d@zytor.com \
    --to=xin@zytor.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=bp@alien8.de \
    --cc=brgerst@gmail.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®