From: Michael Ellerman <mpe@ellerman.id.au>
To: Lennart Sorensen <lsorense@csclub.uwaterloo.ca>,
linux-kernel@vger.kernel.org
Cc: Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org,
Len Sorensen <lsorense@csclub.uwaterloo.ca>
Subject: Re: powerpc: Fix sstep compile on powerpcspe
Date: Wed, 11 May 2016 07:48:45 +1000 (AEST) [thread overview]
Message-ID: <3r4CYn2j81z9t4h@ozlabs.org> (raw)
In-Reply-To: <20160505204444.GE3264@csclub.uwaterloo.ca>
On Thu, 2016-05-05 at 20:44:44 UTC, Lennart Sorensen wrote:
> powerpc: Fix sstep compile on powerpcspe
>
> Commit be96f63375a14ee8e690856ac77e579c75bd0bae introduced ldarx and stdcx
> into the instructions in sstep.c, which are not accepted by the assembler
> on powerpcspe, but does seem to be accepted by the normal powerpc assembler
> even in 32 bit mode.
>
> Wrap these two instructions in a __powerpc64__ check like it is everywhere
> else in the file.
>
> Fixes: be96f63375a1 ("powerpc: Split out instruction analysis part of emulate_step()")
> Signed-off-by: Len Sorensen <lsorense@csclub.uwaterloo.ca>
Applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/03be7e53dee606c189a66a7389
cheers
prev parent reply other threads:[~2016-05-10 21:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 20:44 [PATCH] " Lennart Sorensen
2016-05-05 20:53 ` Lennart Sorensen
2016-05-10 21:48 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3r4CYn2j81z9t4h@ozlabs.org \
--to=mpe@ellerman.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lsorense@csclub.uwaterloo.ca \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®