From: Helge Deller <deller@gmx.de>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
"airlied@gmail.com" <airlied@gmail.com>,
linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Javier Martinez Canillas <javierm@redhat.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH] MAINTAINERS: Add Helge as fbdev maintainer
Date: Tue, 18 Jan 2022 09:41:50 +0100 [thread overview]
Message-ID: <4009cf14-2bb0-a63a-1936-4ac4d757777a@gmx.de> (raw)
In-Reply-To: <CAKMK7uHVHn9apB6YYbLSwu+adEB2Fqp4FM0z582zf4F-v3_GnQ@mail.gmail.com>
Hello Daniel,
On 1/17/22 16:00, Daniel Vetter wrote:
> On Mon, Jan 17, 2022 at 1:16 PM Helge Deller <deller@gmx.de> wrote:
>> On 1/17/22 11:02, Daniel Vetter wrote:
>>> On Fri, Jan 14, 2022 at 7:18 PM Helge Deller <deller@gmx.de> wrote:
>>>>
>>>> The fbdev layer is orphaned, but seems to need some care.
>>>> So I'd like to step up as new maintainer.
>>>>
>>>> Signed-off-by: Helge Deller <deller@gmx.de>
>>>>
>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>> index 5d0cd537803a..ce47dbc467cc 100644
>>>> --- a/MAINTAINERS
>>>> +++ b/MAINTAINERS
>>>> @@ -7583,11 +7583,12 @@ W: http://floatingpoint.sourceforge.net/emulator/index.html
>>>> F: arch/x86/math-emu/
>>>>
>>>> FRAMEBUFFER LAYER
>>>> -L: dri-devel@lists.freedesktop.org
>>>> +M: Helge Deller <deller@gmx.de>
>>>> L: linux-fbdev@vger.kernel.org
>>>> -S: Orphan
>>>
>>> Maybe don't rush maintainer changes in over the w/e without even bothering
>>> to get any input from the people who've been maintaining it before.
>>>
>>> Because the status isn't entirely correct, fbdev core code and fbcon and
>>> all that has been maintained, but in bugfixes only mode. And there's very
>>> solid&important reasons to keep merging these patches through a drm tree,
>>> because that's where all the driver development happens, and hence also
>>> all the testing (e.g. the drm test suite has some fbdev tests - the only
>>> automated ones that exist to my knowledge - and we run them in CI). So
>>> moving that into an obscure new tree which isn't even in linux-next yet is
>>> no good at all.
>>>
>>> Now fbdev driver bugfixes is indeed practically orphaned and I very much
>>> welcome anyone stepping up for that, but the simplest approach there would
>>> be to just get drm-misc commit rights and push the oddball bugfix in there
>>> directly. But also if you want to do your own pull requests to Linus for
>>> that I don't care and there's really no interference I think, so
>>> whatever floats.
>>>
>>> But any code that is relevant for drm drivers really needs to go in through
>>> drm trees, nothing else makes much sense.
>>>
>>> I guess you're first action as newly minted fbdev maintainer is going to be to
>>> clean up the confusion you just created.
>>
>> Most of my machines depend on a working fbdev layer since drm isn't (and probably
>> -due to technical requirements of DRM- won't be) available for those.
>> So, since the fbdev drivers were marked orphaned, I decided to step up as maintainer.
>>
>> I see your point that at least the fbdev core code and fbcon are shared between DRM and fbdev.
>> For me it's really not important to drive any patches through a seperate tree, so
>> I'd be happy to join the drm-misc tree if you feel it's necessary. (By the way,
>> adding my tree to for-next was on my todo list...)
>>
>> What's important for me though is, to keep fbdev actively maintained, which means:
>> a) to get fixes which were posted to fbdev mailing list applied if they are useful & correct,
>
> Yeah it'd be great if we have that, for a while Bart took care of
> these, but had to step down again. drm-misc is maintained with the dim
> scrip suite, which comes with docs and bash completion and everything.
> Good starting pointer is here:
>
> https://drm.pages.freedesktop.org/maintainer-tools/getting-started.html
>
> Process for getting commit rights is documented here:
>
> https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html#drm-misc
>
> But there's a pile more. I think once we've set that up and got it
> going we can look at the bigger items. Some of them are fairly
> low-hanging fruit, but the past 5+ years absolutely no one bothered to
> step up and sort them out. Other problem areas in fbdev are extremely
> hard to fix properly, without only doing minimal security-fixes only
> support, so fair warning there. I think a good starting point would be
> to read the patches and discussions for some of the things you've
> reverted in your tree.
>
> Anyway I hope this gets you started, and hopefully after a minor
> detour: Welcome to dri-devel, we're happy to take any help we can get,
> there's lots to do!
Thanks for this info, Daniel!
After reading those docs I've decided not to join dri-devel and keep
my existing linux-fbdev tree at:
https://git.kernel.org/pub/scm/linux/kernel/git/deller/linux-fbdev.git
The linux-fbdev is a low-volume mailing list with mostly small bug fixes
or enhancements for the fbdev drivers. Those patches usually don't affect DRM.
I'm expecting that non-trivial changes which may affect fbdev will be sent to the
linux-fbdev mailing list, same way as I will of course send any patches which
might affect DRM to dri-devel.
My git tree is wired up to the for-next pull chain, so in any way we would notice
merge conflicts (which I believe will not happen).
Cheers,
Helge
>> b) to include new drivers (for old hardware) if they arrive (probably happens rarely but there can be).
>> I know of at least one driver which won't be able to support DRM....
>> Of course, if the hardware is capable to support DRM, it should be written for DRM and not applied for fbdev.
>> c) reintroduce the state where fbcon is fast on fbdev. This is important for non-DRM machines,
>> either when run on native hardware or in an emulator.
>> d) not break DRM development
>>
>> Especially regarding c) I complained in [1] and got no feedback. I really would like to
>> understand where the actual problems were and what's necessary to fix them.
>>
>> Helge
>>
>> [1] https://lore.kernel.org/r/feea8303-2b83-fc36-972c-4fc8ad723bde@gmx.de
>
>
>
next prev parent reply other threads:[~2022-01-18 8:43 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-14 18:11 Helge Deller
2022-01-14 18:31 ` Geert Uytterhoeven
2022-01-17 9:48 ` Daniel Vetter
2022-01-17 10:02 ` Daniel Vetter
2022-01-17 10:19 ` Javier Martinez Canillas
2022-01-17 10:49 ` Jani Nikula
2022-01-17 10:57 ` Helge Deller
2022-01-17 12:15 ` Helge Deller
2022-01-17 12:57 ` Gerd Hoffmann
2022-01-17 13:29 ` Geert Uytterhoeven
2022-01-17 13:51 ` Thomas Zimmermann
2022-01-17 14:10 ` Geert Uytterhoeven
2022-01-17 14:47 ` Helge Deller
2022-01-17 15:03 ` Daniel Vetter
2022-01-17 20:17 ` Helge Deller
2022-01-18 6:29 ` Gerd Hoffmann
2022-01-18 8:10 ` Geert Uytterhoeven
2022-01-18 11:44 ` Daniel Vetter
2022-01-18 14:23 ` Thomas Zimmermann
2022-01-18 14:39 ` Simon Ser
2022-01-20 12:50 ` Gerd Hoffmann
2022-01-21 8:55 ` Daniel Vetter
2022-01-24 18:38 ` Geert Uytterhoeven
2022-01-24 18:50 ` Daniel Vetter
2022-01-24 19:05 ` Thomas Zimmermann
2022-01-18 8:20 ` Helge Deller
2022-01-18 9:16 ` Gerd Hoffmann
2022-01-18 10:13 ` Helge Deller
2022-01-18 10:44 ` Helge Deller
2022-01-18 12:48 ` Gerd Hoffmann
2022-01-17 15:05 ` Thomas Zimmermann
2022-01-17 16:05 ` Helge Deller
2022-01-17 14:53 ` Thomas Zimmermann
2022-01-18 6:11 ` Gerd Hoffmann
2022-01-18 8:09 ` Helge Deller
2022-01-17 15:00 ` Daniel Vetter
2022-01-17 15:42 ` Helge Deller
2022-01-17 15:56 ` Daniel Vetter
2022-01-17 15:58 ` Thomas Zimmermann
2022-01-17 16:21 ` Helge Deller
2022-01-17 16:38 ` Daniel Vetter
2022-01-17 17:19 ` Helge Deller
2022-01-17 19:45 ` Helge Deller
2022-01-17 21:55 ` Ilia Mirkin
2022-01-18 11:14 ` Daniel Vetter
2022-01-18 14:14 ` Thomas Zimmermann
2022-01-17 21:40 ` Jani Nikula
2022-01-17 21:44 ` Helge Deller
2022-01-18 8:38 ` Jani Nikula
2022-01-18 8:41 ` Geert Uytterhoeven
2022-01-18 11:41 ` Daniel Vetter
2022-01-18 12:11 ` Simon Ser
2022-01-18 8:54 ` Helge Deller
2022-01-18 9:33 ` Javier Martinez Canillas
2022-01-18 9:45 ` Geert Uytterhoeven
2022-01-18 11:18 ` Daniel Vetter
2022-01-18 11:42 ` Helge Deller
2022-01-18 8:41 ` Helge Deller [this message]
2022-01-18 9:12 ` Helge Deller
2022-01-17 11:16 ` Thomas Zimmermann
2022-01-17 11:33 ` Helge Deller
2022-01-17 12:13 ` Thomas Zimmermann
2022-01-17 18:47 ` Sven Schnelle
2022-01-18 8:33 ` Pekka Paalanen
2022-01-18 9:53 ` Gerd Hoffmann
2022-01-18 11:22 ` Daniel Vetter
2022-01-18 12:07 ` Gerd Hoffmann
2022-01-19 8:39 ` Pekka Paalanen
2022-01-20 9:06 ` Geert Uytterhoeven
2022-01-20 11:32 ` Daniel Vetter
2022-01-20 12:13 ` Geert Uytterhoeven
2022-01-20 12:33 ` Daniel Vetter
2022-01-20 12:46 ` Geert Uytterhoeven
2022-01-24 18:50 ` Geert Uytterhoeven
2022-01-24 19:37 ` Daniel Vetter
2022-01-20 11:51 ` Gerd Hoffmann
2022-01-18 8:58 ` Michel Dänzer
2022-01-18 10:05 ` Sven Schnelle
2022-01-18 14:06 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4009cf14-2bb0-a63a-1936-4ac4d757777a@gmx.de \
--to=deller@gmx.de \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=geert@linux-m68k.org \
--cc=javierm@redhat.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®