From: Mike Travis <travis@sgi.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Takashi Iwai <tiwai@suse.de>, <alsa-devel@alsa-project.org>,
<perex@perex.cz>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ALSA: hda - allow 40 bit DMA mask for NVidia devices
Date: Tue, 18 Oct 2016 06:04:31 -0700 [thread overview]
Message-ID: <40321a07-bff4-4293-d85b-bddba31d1c33@sgi.com> (raw)
In-Reply-To: <CAKv+Gu9xTbnt+qoDjj3CHMbFTf_TWsF-QdCZnAS3dKZ+EBfOpQ@mail.gmail.com>
On 10/18/2016 5:49 AM, Ard Biesheuvel wrote:
> On 18 October 2016 at 13:46, Mike Travis <travis@sgi.com> wrote:
>>
>> Have you tested this change on a system which has physical
>> addressing > 40 bits to insure that addresses > 40 bits are
>> not simply truncated to an incorrect (mod 40) address?
>
> The device should never see addresses > 40 bits, given that the DMA
> mask is set to 40 bits not 64.
I agree that the device should never see that. But how is that
restriction imposed? If a user presents an buffer address > 40 bits
how would that be converted to useful buffer at <= 40 bits?
I believe I tried this (at the time the kernel was at version 2.6)
and it did not work. Since audio I/O was such a low (relative)
bandwidth, it was not worth the effort to rework the audio code
to allow buffers > 32 bits but <= 40 bits. It may have changed
since then?
>
>> By not restricting the addresses to 32 bits you are not
>> restricting the device to the DMA32 zone.
>>
>> This is what caused the original panic on UV systems.
>>
>> Btw, the newest nVidia GPUs have > 40 bits of DMA address bits.
>>
>
> Thanks,
> Ard.
>
next prev parent reply other threads:[~2016-10-18 13:04 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-17 16:23 Ard Biesheuvel
2016-10-18 10:25 ` Takashi Iwai
2016-10-18 10:26 ` Ard Biesheuvel
2016-10-18 12:46 ` Mike Travis
2016-10-18 12:49 ` Ard Biesheuvel
2016-10-18 13:04 ` Mike Travis [this message]
2016-10-18 13:15 ` Ard Biesheuvel
2016-10-18 14:10 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40321a07-bff4-4293-d85b-bddba31d1c33@sgi.com \
--to=travis@sgi.com \
--cc=alsa-devel@alsa-project.org \
--cc=ard.biesheuvel@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®