[PATCH] memory leak in devpts in 2.4.x

[PATCH] memory leak in devpts in 2.4.x

[Kirill Korotaev]

[-- Attachment #1: Type: text/plain, Size: 67 bytes --]

 small memory leak in devpts_read_super() on error path.

 Kirill
 

[-- Attachment #2: devpts.diff --]
[-- Type: application/octet-stream, Size: 717 bytes --]

--- ./fs/devpts/inode.c.dpts	2004-04-08 08:38:17.000000000 +0400
+++ ./fs/devpts/inode.c	2004-04-08 08:41:56.000000000 +0400
@@ -143,12 +143,12 @@ struct super_block *devpts_read_super(st
 
 	if ( devpts_parse_options(data,sbi) && !silent) {
 		printk("devpts: called with bogus options\n");
-		goto fail_free;
+		goto fail_inode;
 	}
 
 	inode = new_inode(s);
 	if (!inode)
-		goto fail_free;
+		goto fail_inode;
 	inode->i_ino = 1;
 	inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME;
 	inode->i_blocks = 0;
@@ -170,6 +170,8 @@ struct super_block *devpts_read_super(st
 	
 	printk("devpts: get root dentry failed\n");
 	iput(inode);
+fail_inode:
+	kfree(sbi->inodes);
 fail_free:
 	kfree(sbi);
 fail:

[PATCH] memory access to free memory in 2.4.x

[Kirill Korotaev]

[-- Attachment #1: Type: text/plain, Size: 54 bytes --]

memory access to files which are already put.

Kirill

[-- Attachment #2: proc-putfiles.diff --]
[-- Type: application/octet-stream, Size: 293 bytes --]

--- linux-2.4.20/fs/proc/base.c.saved	Sat Apr  5 13:57:45 2003
+++ linux-2.4.20/fs/proc/base.c	Sat Apr  5 13:58:03 2003
@@ -825,8 +825,8 @@
 	return NULL;
 
 out_unlock2:
-	put_files_struct(files);
 	read_unlock(&files->file_lock);
+	put_files_struct(files);
 out_unlock:
 	iput(inode);
 out: