From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linusw@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM
Date: Fri, 22 May 2026 13:15:45 +0200 [thread overview]
Message-ID: <40413c01-117a-4333-a8de-f4cc9934dd50@oss.qualcomm.com> (raw)
In-Reply-To: <20260513140009.3841770-3-ajay.nandam@oss.qualcomm.com>
On 5/13/26 4:00 PM, Ajay Kumar Nandam wrote:
> Convert the LPASS LPI pinctrl driver to use the PM clock framework for
> runtime power management.
>
> This allows the LPASS LPI pinctrl driver to drop clock votes when idle,
> improves power efficiency on platforms using LPASS LPI island mode, and
> aligns the driver with common runtime PM patterns used across Qualcomm
> LPASS subsystems.
>
> Guard GPIO register read/write helpers and slew-rate register programming
> with synchronous runtime PM calls so the device is active during MMIO
> operations whenever autosuspend is enabled.
>
> Signed-off-by: Ajay Kumar Nandam <ajay.nandam@oss.qualcomm.com>
> ---
Looks good now, couple of style nits since I asked for another revision:
[...]
> @@ -107,8 +118,8 @@ static int lpi_gpio_set_mux(struct pinctrl_dev *pctldev, unsigned int function,
> {
> struct lpi_pinctrl *pctrl = pinctrl_dev_get_drvdata(pctldev);
> const struct lpi_pingroup *g = &pctrl->data->groups[group];
> - u32 val;
> - int i, pin = g->pin;
> + u32 val, io_val;
> + int i, pin = g->pin, ret;
reverse-Christmas-tree ordering would be neat
[...]
> u32p_replace_bits(&val, i, LPI_GPIO_FUNCTION_MASK);
> - lpi_gpio_write(pctrl, pin, LPI_GPIO_CFG_REG, val);
> - mutex_unlock(&pctrl->lock);
> -
> - return 0;
> + return lpi_gpio_write(pctrl, pin, LPI_GPIO_CFG_REG, val);
A \n before return statements is customary
> }
>
> static const struct pinmux_ops lpi_gpio_pinmux_ops = {
> @@ -162,11 +178,15 @@ static int lpi_config_get(struct pinctrl_dev *pctldev,
> unsigned int param = pinconf_to_config_param(*config);
> struct lpi_pinctrl *state = dev_get_drvdata(pctldev->dev);
> unsigned int arg = 0;
> + int ret;
> int is_out;
> int pull;
> u32 ctl_reg;
ditto
[...]
> @@ -206,7 +226,7 @@ static int lpi_config_set_slew_rate(struct lpi_pinctrl *pctrl,
> {
> unsigned long sval;
> void __iomem *reg;
> - int slew_offset;
> + int slew_offset, ret;
ditto
[...]
> diff --git a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> index 750f410311a8..a61df10d46cb 100644
> --- a/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
> +++ b/drivers/pinctrl/qcom/pinctrl-sc7280-lpass-lpi.c
As noted, please move to patch1
Konrad
next prev parent reply other threads:[~2026-05-22 11:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-13 14:00 [PATCH v5 0/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework Ajay Kumar Nandam
2026-05-13 14:00 ` [PATCH v5 1/2] pinctrl: qcom: lpass-lpi: Enable runtime PM hooks on LPASS LPI SoCs Ajay Kumar Nandam
2026-05-22 11:13 ` Konrad Dybcio
2026-05-13 14:00 ` [PATCH v5 2/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM Ajay Kumar Nandam
2026-05-22 11:15 ` Konrad Dybcio [this message]
2026-05-22 20:33 ` [PATCH v6 0/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework Ajay Kumar Nandam
2026-05-22 20:33 ` [PATCH v6 1/2] pinctrl: qcom: lpass-lpi: Enable runtime PM hooks on LPASS LPI SoCs Ajay Kumar Nandam
2026-05-22 20:33 ` [PATCH v6 2/2] pinctrl: qcom: lpass-lpi: Switch to PM clock framework for runtime PM Ajay Kumar Nandam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40413c01-117a-4333-a8de-f4cc9934dd50@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=ajay.nandam@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®