From: Michal Schmidt <xschmi00@stud.feec.vutbr.cz>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.26-pre2
Date: Sun, 07 Mar 2004 21:08:15 +0100 [thread overview]
Message-ID: <404B812F.7000204@stud.feec.vutbr.cz> (raw)
In-Reply-To: <Pine.LNX.4.44.0403061618420.4428-100000@dmt.cyclades>
Hello,
> <mlord:pobox.com>:
> o Fix vmalloc() error handling
>
This change has a problem. In __vmalloc_area_pages when pmd_alloc fails,
the spinlock will not be released. Maybe the following patch is needed?
(only compile tested, I don't have SMP)
Michal Schmidt
--- linux-2.4.26-pre2/mm/vmalloc.c Sun Mar 7 20:44:27 2004
+++ linux-2.4.26-pre2.mich/mm/vmalloc.c Sun Mar 7 20:54:02 2004
@@ -183,6 +183,7 @@ static inline int __vmalloc_area_pages (
err:
if (address > start)
vmfree_area_pages((address - start), address - start);
+ spin_unlock(&init_mm.page_table_lock);
return -ENOMEM;
}
prev parent reply other threads:[~2004-03-07 20:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-06 19:20 Marcelo Tosatti
2004-03-07 5:44 ` Eyal Lebedinsky
2004-03-07 16:19 ` Horst von Brand
2004-03-07 18:49 ` Roland Dreier
2004-03-07 19:42 ` Michael Frank
2004-03-07 19:25 ` David Weinehall
2004-03-07 19:52 ` Rene Herman
2004-03-07 19:58 ` Jeff Garzik
2004-03-07 20:05 ` David Weinehall
2004-03-07 20:58 ` Michael Frank
2004-03-07 20:08 ` Michal Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=404B812F.7000204@stud.feec.vutbr.cz \
--to=xschmi00@stud.feec.vutbr.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®